Creating Min Heap from STL Priority Queue

Question

I am creating a min heap from stl priority queue. Here is my class which I am using.

class Plane
{
  private :
    int id ;
    int fuel ;
 public:
    Plane():id(0), fuel(0){}
    Plane(const int _id, const int _fuel):id(_id), fuel(_fuel) {}

    bool operator > (const Plane &obj)
    {
        return ( this->fuel > obj.fuel ? true : false ) ;
    }

} ;

In main I instantiate an object thus.

 priority_queue<Plane*, vector<Plane*>, Plane> pq1 ;
 pq1.push(new Plane(0, 0)) ;

I am getting an error from xutility which I am unable to understand.

d:\microsoft visual studio 10.0\vc\include\xutility(674): error C2064: term does not evaluate to a function taking 2 arguments

Any help to its solution would be appreciated.

Fred Foo · Answer 1 · 2012-12-07T15:26:46.613

12

If you drop the use of pointers (which are overkill for your simple structures), then you can use std::greater from the header functional:

std::priority_queue<Plane, std::vector<Plane>, std::greater<Plane> > pq1;
pq1.push(Plane(0, 0));

Currently, you are feeding Plane as the comparison type. That won't work since the comparison type must be a type of function object, i.e. it must have an operator() that does the comparison. Plane doesn't have such a member (and adding it just for this purpose would be a bad idea).

std::greater has the appropriate method, implemented in terms of your operator>. However, it doesn't work with pointers, because then it uses a pointer comparison (based on memory addresses).

Btw., note that your comparison function can be expressed more succinctly as

bool operator>(const Plane &other)
{
    return fuel > other.fuel;
}

edited Dec 07 '12 at 15:26

answered Dec 07 '12 at 15:08

Fred Foo

355,277
75
744
836

Okay but for an upvote from me this answer needs an explanation of why the element type is an unsuitable comparator type and consequently why the OP's original code did not compile. :-) – Lightness Races in Orbit Dec 07 '12 at 15:09
1

It works fine, but I cannot get the reason behind that, as @Lightness Races in Orbit mentions. – Sasha Dec 07 '12 at 15:12
@larsmans how would it know that it has to order according to my fuel? – Sasha Dec 07 '12 at 15:25
`std::greater` will invoke your `operator>`. It just knows to do that. – Lightness Races in Orbit Dec 07 '12 at 15:26
@LightnessRacesinOrbit: too bad you didn't catch the gravest error of all: `std::greater` would do a pointer comparison. Changed the answer, again. – Fred Foo Dec 07 '12 at 15:28
@larsmans But I have to create a dynamic object each at each time unit. I cannot simply drop the pointers. – Sasha Dec 07 '12 at 15:30
@Sasha: then the other answer is what you need. You can't overload `operator>` on pointers, because it's already defined. – Fred Foo Dec 07 '12 at 15:35

juanchopanza · Accepted Answer · 2012-12-07T15:38:30.447

7

The third template parameter must be a binary functor taking teo Plane*. Your Plane class does not provide that.

You need something of the form

struct CompPlanePtrs
{
  bool operator()(const Plane* lhs, const Plane* rhs) const {
    return lhs->fuel > rhs->fuel ;
  }
};

edited Dec 07 '12 at 15:38

answered Dec 07 '12 at 15:03

juanchopanza

223,364
34
402
480

Can't i do that with operator >?. making it a friend? It doesnt get right with operator() either. – Sasha Dec 07 '12 at 15:06
1

@Sasha the problem is that you need to compare *pointers* to `Planes`, not `Planes`. You cannot overload `operator>` for pointers. – juanchopanza Dec 07 '12 at 15:44

Creating Min Heap from STL Priority Queue

2 Answers2

Linked