Simplifying Lists

Question

How Can This Code Be Simplified? That is the question.

    stat_keys.append(self.request.get("stat_one"))
    stat_keys.append(self.request.get("stat_two"))
    stat_keys.append(self.request.get("stat_three"))
    stat_keys.append(self.request.get("stat_four"))

score 3 · Accepted Answer · answered Nov 26 '12 at 07:27

stat_keys += [self.request.get(k) for k in ('stat_one', 'stat_two', 'stat_three', 'stat_four')]

or

stat_keys += map(self.request.get, ('stat_one', 'stat_two', 'stat_three', 'stat_four')))

or

map(stat_keys.append, map(self.request.get, ('stat_one', 'stat_two', 'stat_three', 'stat_four')))

I suggest the first one, though.

score 1 · Answer 2 · answered Nov 26 '12 at 07:26

Difficult to answer without knowing what any of the variables are, but how about this:

for stat in ('stat_one', 'stat_two', 'stat_three', 'stat_four'):
    stat_keys.append(self.request.get(stat))

Or, using a generator expression:

[stat_keys.append(self.request.get(stat)) for stat in ('stat_one', 'stat_two', 'stat_three', 'stat_four')]

score 1 · Answer 3 · answered Nov 26 '12 at 07:31

1

Change to .extend() with a generator expression:

stat_keys.extend(self.request.get(stat) for stat in('stat_one', 'stat_two', 'stat_three', 'stat_four'))

answered Nov 26 '12 at 07:31

Jon Clements

138,671
33
247
280

Assuming that `stat_keys` supports `extend`, which we don't know from the information in the question. – aquavitae Nov 26 '12 at 08:29

Shawn Zhang · Answer 4 · 2012-11-26T07:38:09.553

0

s_list = [ "stat_one", "stat_two", "stat_three", "stat_four" ]
[ stat_keys.append(self.request.get(s)) for s in s_list ]

edited Nov 26 '12 at 07:38

answered Nov 26 '12 at 07:31

Shawn Zhang

1,680
1
12
21

Simplifying Lists

4 Answers4