Remove function creation in loop - closure

Question

I want to remove the function creation in my code, but I don't know how? Can anyone here help me?

    for (var eventName in this.events) {
        var eventFunc = this.events[eventName],
            splitEventName = eventName.split(" "),
            eventType = splitEventName[0],
            eventUI = splitEventName[1];

        Utilities.addEventListener(this.ui[eventUI], eventType, (function(view, eventFunc) {
            return function(e) {
                eventFunc.call(view, e);
            };
        }(this, eventFunc)));
    }

score 3 · Accepted Answer · answered Nov 22 '12 at 13:24

3

You could move your immediately-invoked function expression out of the loop and turn it into a normal function declaration. Then you can simply call it on each iteration:

function makeEventListener(view, eventFunc) {
    return function (e) {
        eventFunc.call(view, e);
    };
}
for (var eventName in this.events) {
    var eventFunc = this.events[eventName],
        splitEventName = eventName.split(" "), 
        eventType = splitEventName[0],
        eventUI = splitEventName[1];
    Utilities.addEventListener(this.ui[eventUI], eventType, makeEventListener(this, eventFunc));
}

answered Nov 22 '12 at 13:24

James Allardice

164,175
21
332
312

Okey, thanks. That was easy.. :-) *I have to wait 9 mintures before I can accept. – TryingToImprove Nov 22 '12 at 13:26
you should also check for `this.events.hasOwnProperty(eventName))` when trying to executing the body of your `for`-loop. – nozzleman Nov 22 '12 at 13:35
Yeah, I know, but if it only is for a { example: "ads" }, is it then necessary? – TryingToImprove Nov 22 '12 at 13:46

Remove function creation in loop - closure

1 Answers1