Deprecated: mktime(): The is_dst parameter is deprecated

Question

standard function: ( see on codepad )

<?php

$start_time_o = "18:00";
$end_time_o = date("H:i");

function get_time_difference(){

    global $start_time_o, $end_time_o;

    $start_time = explode(":", $start_time_o);
    $end_time = explode(":", $end_time_o);

    $start_time_stamp = mktime($start_time[0], $start_time[1], 0, 0, 0, 0);
    $end_time_stamp = mktime($end_time[0], $end_time[1], 0, 0, 0, 0);

    $time_difference = $end_time_stamp - $start_time_stamp;

    return gmdate("H:i", $time_difference); 
}

echo get_time_difference();

?>

modified function: ( see on codepad )

<?php

$start_time_o = "18:00:01";
$end_time_o = date("H:i:s");

function get_time_difference(){

    global $start_time_o, $end_time_o;

    $start_time = explode(":", $start_time_o);
    $end_time = explode(":", $end_time_o);

    $start_time_stamp = mktime($start_time[0], $start_time[1], $start_time[2], 0, 0, 0, 0);
    $end_time_stamp = mktime($end_time[0], $end_time[1], $end_time[2], 0, 0, 0, 0);

    $time_difference = $end_time_stamp - $start_time_stamp;

    return gmdate("H:i:s", $time_difference); 
}

echo get_time_difference();

?>

the first function works without any errors or notices.

the modified function gives the message:

Deprecated: mktime(): The is_dst parameter is deprecated in C:\xampp\htdocs\index.php on line 13
Deprecated: mktime(): The is_dst parameter is deprecated in C:\xampp\htdocs\index.php on line 14

i don't know why i receive the message only at the modified function? what's wrong in here?

You are using one argument too many on the `mktime()` function — Ben Carey, Nov 18 '12 at 18:31

score 3 · Answer 1 · answered Nov 18 '12 at 18:32

3

use strtotime

like

$someString = '10/10/2012 4:34 pm';  
date_default_timezone_set('American/New_York');
$timestamp = strtotime($someString);
echo date('Y/m/d H:i:s', $timestamp);

answered Nov 18 '12 at 18:32

NullPoiиteя

56,591
22
125
143

1

+1 Much better way to achieve what the question is trying to do :-) – Ben Carey Nov 18 '12 at 18:36

John Conde · Answer 2 · 2012-11-18T19:22:01.000

3

If you wanted to use a simpler way to do this try using DateTime::diff

<?php
$datetime1 = new DateTime('18:00:01');
$datetime2 = new DateTime();
$interval = $datetime1->diff($datetime2);
echo $interval->format('H:i:s');
?>

Here it is as a function which may make it easier for you to use:

<?php
function diff($first_datetime, $second_datetime = "now")
{
    $datetime1 = new DateTime($first_datetime);
    $datetime2 = new DateTime($second_datetime);
    $interval = $datetime1->diff($datetime2);
    return $interval->format('H:i:s');
}

// One of the date/time parameters is now so 
// we only  have to pass one parameter
echo diff('18:00:01');

// Neither parameter is now
echo diff('18:00:01', '20:00:00');
?>

edited Nov 18 '12 at 19:22

answered Nov 18 '12 at 18:37

John Conde

217,595
99
455
496

2

+1 Another good answer, but may be too advanced for @bernte as it uses objects :-) – Ben Carey Nov 18 '12 at 18:38
hi john.. i tried your small code :) but i don't receive the result i want.. i get the difference in +1h.. and -1h format.. but i need the absolute time – bernte Nov 18 '12 at 19:29
for echo diff('18:00:01', '17:00:01'); i get 01:00:00 but i need 23:00:00. is that possible? – bernte Nov 18 '12 at 19:50
Just switching the order of the parameters *should* do it – John Conde Nov 18 '12 at 19:52
no that doesn't work.. i get the same result (01:00:00). 18:00:01 is today and 17:00:01 is yesterday – bernte Nov 18 '12 at 19:59

score 2 · Answer 3 · answered Nov 18 '12 at 18:33

You are using one too many arguments on the mktime() function. Remove one of the zeros, like this:

$start_time_stamp = mktime($start_time[0], $start_time[1], $start_time[2], 0, 0, 0);
$end_time_stamp = mktime($end_time[0], $end_time[1], $end_time[2], 0, 0, 0);

This is what is causing your issue, however as @NullPointer has pointed out in his answer, there is a much more efficient and better way to achieve this. Use his solution!

Deprecated: mktime(): The is_dst parameter is deprecated

3 Answers3