5

I'm passing some data to a View from my controller, which I wish to display inside a partial view inside that View (don't ask, it's complicated). I know I probably shouldn't even be passing a model to a view that's inded for another view, but I've noticed that the partial view is actually inheriting the Model from the parenmt View:

public ActionResult Index(){

 Person p = new Person
 {
    FName = "Mo",
    LName = "Sep"

 };

 return View(p);

}

Then inside my Index View I have:

<h2>Index</h2>

@Html.Partial("_IndexPartial")

and Inside _IndexPartial I have:

@Model.FName

and this Prints "Mo".

Is this behaviour intended like that in WPF where child controls inherit the data context of their parent View? And is it considered bad practise to use this in your application?

Thanks.

tereško
  • 58,060
  • 25
  • 98
  • 150
Mohammad Sepahvand
  • 17,364
  • 22
  • 81
  • 122

2 Answers2

5

Is this behaviour intended like that in WPF where child controls inherit the data context of their parent View?

Yes.

I see you are not currently passing any model to the Would it work to just inherit the layouts, and then not need to use the partial at all?

If you want to keep using it like you are, maybe just be more explicit about it, and pass the current model to the partial.

@Html.Partial("_IndexPartial", Model)

If you look at the source for Html.Partial(view):

public static MvcHtmlString Partial(this HtmlHelper htmlHelper, string partialViewName)
{
    return Partial(htmlHelper, partialViewName, null /* model */, htmlHelper.ViewData);
}

It is passing the model via htmlHelper.ViewData, you can access the model in the same way in your view with @{ViewData.Model}, but this is NOT a good practice.

slipsec
  • 3,004
  • 3
  • 34
  • 46
  • 1
    I agree with @slipsec and his detailed answer. It is by design that a View's model is available to the partial view. The partial view becomes "a part" of the "parent" view by whom it was invoked. I would suggest that best practice is to explicitly assign the Model to the partial view. I often pass a part (not all) of my Model to the partial, ie. @Html.Partial("_myPartialView", Model.SubsetOfData) – kingdango Nov 17 '12 at 14:25
1

You can pass the model into the partial view as a second parameter using the overload:

@Html.Partial("viewname", Model)

Nothing wrong with this approach IMO as its the whole point in strongly-typed views and the benefits they bring...

LDJ
  • 6,896
  • 9
  • 52
  • 87