7

I'm using template toolkit to form a simple JSON response (see the code below). I need to put a comma after all elements of the response except the last.

I believe I need to make use of TTs iterator, however I'm not getting it right.
With this code, a comma is still printed on the end of the last element.

The problem lies with the section that contains

[% UNLESS outer.last && loop.last %],[% END %]

this should add a comma unless the outer and inner loops are on their last iteration.

Any help on what I'm getting wrong greatly appreciated.

{ "success": true, "filesdata": [
[%~ USE outer = iterator(objects); FOREACH object IN outer;
    FOREACH rep IN object.reps;
        IF rep.rep == reptype %]
{ "id":"[% object.id | xml %]", "url":"[% rep.src | xml %]", "story":"[% object.story | xml %]" }[% UNLESS outer.last && loop.last %],[% END %]
        [%~ END;
    END;
END ~%]
] }
mark
  • 1,769
  • 3
  • 19
  • 38

2 Answers2

9

This works for me:

[% IF loop.last %]}[% ELSE %]},[% END %]
Twistar
  • 782
  • 5
  • 21
  • 35
6

Have you tried using the join vmethod? You can create a list and join it with a comma:

[% items.join(', ') %]

Having said that, you may also want to look at Template::Plugin::SimpleJson. You could create a hash and then pass it to this plugin. However you do decide to do it, you probably don't want to worry about quoting your JSON in the actual template file and using something like this could save you some heartache down the line.

There's also the option of creating the JSON outside of the template itself, but that's outside the scope of your question.

oalders
  • 5,239
  • 2
  • 23
  • 34
  • I would reiterate what oalders said about using a plug-in. Personally, I like Template::Plugin::JSON::Escape, but the important thing is to avoid hand-crafted code generation. You greatly increase the risk of an unexpected condition/value causing your template to explode at run-time. – RET Nov 01 '12 at 23:23