SqlDataAdapter does not fill DataSet

Question

I'm using VS2012 and SQL Server Express 2008. I've boiled down my connection/query to try and find out why my DataSet is not being filled. The connection is completed successfully, and no exceptions are thrown, but the adapter does not fill the DataSet. The database that this is pulling from is on the same PC and using localhost\SQLEXPRESS does not change the result. Thanks for any input!

SqlConnection questionConnection = new SqlConnection(ConfigurationManager.ConnectionStrings["DefaultConnection"].ConnectionString);
questionConnection.Open();
String sql = "SELECT * FROM HRA.dbo.Questions";
SqlDataAdapter adapter = new SqlDataAdapter();
DataSet ds = new DataSet();
SqlCommand command = new SqlCommand(sql, questionConnection);
adapter.SelectCommand = command;
adapter.Fill(ds);
adapter.Dispose();
command.Dispose();
questionConnection.Close();

Connection String:

<add name="DefaultConnection" providerName="System.Data.SqlClient" connectionString="Data Source=CODING-PC\SQLEXPRESS;Initial Catalog=HRA;User ID=sa; Password= TEST" />

Check data is there are not........... you will get data in ds.Tables[0] — andy, Oct 30 '12 at 12:07

score 7 · Accepted Answer · answered Oct 30 '12 at 12:09

7

try this:

SqlConnection questionConnection = new SqlConnection(ConfigurationManager.ConnectionStrings["DefaultConnection"].ConnectionString);
questionConnection.Open();
DataSet ds = new DataSet();
String sql = "SELECT * FROM HRA.dbo.Questions";
SqlDataAdapter adapter = new SqlDataAdapter(sql, questionConnection);
adapter.Fill(ds);

adapter.Dispose();
command.Dispose();
questionConnection.Close();

answered Oct 30 '12 at 12:09

AnandPhadke

13,160
5
26
33

7

Can you explain the difference? "Try this" is not really helpful. – Tim Schmelter May 18 '15 at 14:37

score 7 · Answer 2 · answered Oct 30 '12 at 12:28

It appears the answer has already been found, however, I am posting one anyway to advocate the use of using blocks, and also letting the .NET framework do the hardwork for you. Your 11 lines of code can be rewritten in 3:

DataSet ds = new DataSet();
using (var adapter = new SqlDataAdapter("SELECT * FROM HRA.dbo.Questions", ConfigurationManager.ConnectionStrings["DefaultConnection"].ConnectionString))
{
    adapter.Fill(ds);
}

score 0 · Answer 3 · answered Oct 30 '12 at 12:10

0

Is "HRA.dbo.Questions" an actual table?

Your connectionstring contains an Initial Catalog with value "HRA", and the SQL should only contain dbo.Questions as far as I know.

answered Oct 30 '12 at 12:10

MarioDS

12,895
15
65
121

1

This does not matter here.Connection string property is just to connect to the server and DB. – AnandPhadke Oct 30 '12 at 12:11

score 0 · Answer 4 · answered Apr 15 '21 at 06:10

0

Check that you dont have the fill statement in another part of the code such as in the page load event.

answered Apr 15 '21 at 06:10

Robert Peter Bronstein

166
1
8

SqlDataAdapter does not fill DataSet

4 Answers4

Linked