2

This example can be easily tested in the groovy console.

var a is evaluated to not null while b is evaluated to null.

Both are instances of org.codehaus.groovy.runtim.NullObject

def b = null

println b.getClass()
println b == null

def a = null.getClass().newInstance()

println a.getClass()
println a == null

Does anyone knows why?

This is a tricky thing when dealing with reflection code.

lfrodrigues
  • 305
  • 3
  • 11

2 Answers2

1

Actually I am wondering if this is not a bug. As an explanation... NullObject is a runtime/intermediate kind of Object. If you do anything on null, then NullObject is used. This, and the the implementation of NullObject#equals speaks for a==null returning true. It returns fails, because there is some internal code before that, that is for example determining if compareTo is called instead of equals and such things. Now this piece of code starts with

if (left == right) return true; 
if (left == null || right == null) return false;

so null==null will return true, but NullObject==null will return false. On the other hand NullObject should not leak out if possible. Maybe we should fix newInstance() to return null.

I filled http://jira.codehaus.org/browse/GROOVY-5769 for this

Lifeweaver
  • 986
  • 8
  • 29
blackdrag
  • 6,413
  • 2
  • 26
  • 38
0

In the equals method of NullObject, it only returns true if you are comparing it to null

As an instance of NullObject is not strictly null, it returns false...

Whether NullObject should return true if you call equals against another NullObject is probably a question best asked on the mailing list... I'll have a look and see if I can find any previous question.

tim_yates
  • 167,322
  • 27
  • 342
  • 338
  • But in this case both objects are NullObjects, right? Or "b" is strictly null and the b.getClass() is obfuscating it? – lfrodrigues Oct 25 '12 at 13:16
  • Yeah, both objects are `NullObject`. `NullObject.equals` *specifically* (see link above) checks `to == null` and this evaluates to `false` as `NullObject != null` in the Java implementation.... Not sure I'm explaining very well... – tim_yates Oct 25 '12 at 13:26
  • I can't see why. In both cases there will be "to == null" with the "to" object as an NullObject. – lfrodrigues Oct 25 '12 at 13:41
  • Yeah, and in Java (which NullObject is written in), only `null == null`... `NullObject != null` – tim_yates Oct 25 '12 at 13:43