16

I'm trying to determine if a Session variable exists, but I'm getting the error:

System.NullReferenceException: Object reference not set to an instance of an object.

Code:

    // Check if the "company_path" exists in the Session context
    if (System.Web.HttpContext.Current.Session["company_path"].ToString() != null)
    {
        // Session exists, set it
        company_path = System.Web.HttpContext.Current.Session["company_path"].ToString();
    }
    else
    {
        // Session doesn't exist, set it to the default
        company_path = "/reflex/SMD";
    }

That is because the Session name "company_path" doesn't exist, but I can't detect it!

Adil
  • 146,340
  • 25
  • 209
  • 204
Luke
  • 22,826
  • 31
  • 110
  • 193

3 Answers3

37

Do not use ToString() if you want to check if Session["company_path"] is null. As if Session["company_path"] is null then Session["company_path"].ToString() will give you exception.

Change

if (System.Web.HttpContext.Current.Session["company_path"].ToString() != null)
{
    company_path = System.Web.HttpContext.Current.Session["company_path"].ToString();
}
else
{
    company_path = "/reflex/SMD";
}

To

if (System.Web.HttpContext.Current.Session["company_path"]!= null)
{
      company_path = System.Web.HttpContext.Current.Session["company_path"].ToString();
}
else
{
      company_path = "/reflex/SMD";
}
Adil
  • 146,340
  • 25
  • 209
  • 204
3

This can be solved as a one liner in the latest version of .NET using a null-conditional ?. and a null-coalesce ??:

// Check if the "company_path" exists in the Session context
company_path = System.Web.HttpContext.Current.Session["company_path"]?.ToString() ?? "/reflex/SMD";

Links:

https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/operators/null-coalescing-operator https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/operators/null-conditional-operators

Luke
  • 22,826
  • 31
  • 110
  • 193
0

If deploying on Azure (as of August 2017), it is useful to also check if the Session keys array is populated, e.g.:

Session.Keys.Count > 0 && Session["company_path"]!= null
Manish
  • 1,726
  • 3
  • 23
  • 29