3

I'm writing some unit tests for WebAPI controllers, and one of the aspects that I want to assert is that the parameters match.

I've followed the method used in Filip Wojcieszyn's blog, which is working fine, but I'm now looking to extend its assertions.

I have three actions on a controller (all three of which have been verified through actual use):

[HttpGet]
public IEnumerable<Task> Get()

[HttpGet]
public IEnumerable<Task> Get(string elementType)

[HttpGet]
public Task Get(long id)

And I have the following code

var actionSelector = new ApiControllerActionSelector();
var descriptor = actionSelector.SelectAction(_controllerContext);
return descriptor.GetParameters();

The problem is that when I call descriptor.GetParameters() on the parameterless route it returns a collection containing 1 parameter - the "long id" param.

Can anyone explain why it returns only this and neither of the other two overloads, and if it's possible to obtain the overload possibilities?

awj
  • 7,482
  • 10
  • 66
  • 120

1 Answers1

3

The cause of the problem was that the route which was being invoked was not specific enough.

  • I had a route which allowed the ID parameter to be optional
  • On the controller are 3 overloads of Get().
  • The Get(long id) action was chosen because although no 'id' parameter was specified, the 'id' parameter is optional and therefore this method fits.

The WebAPI selects the method with the greatest number of matching parameters, which in this case meant that on the line of code

var descriptor = actionSelector.SelectAction(_controllerContext);

An unexpected action was being selected - unexpected because I was looking for Get() and was being given Get(long id).

To solve this I simply split my configured route into two: the first one expects (i.e. non-optional) an 'id' parameter, and a more general route which does not accept an 'id' parameter.

Then everything fell into place.

awj
  • 7,482
  • 10
  • 66
  • 120
  • this is exactly what is occurring with me. – Skadoosh Jan 22 '13 at 19:33
  • Did you put that route before or after the default route? I have 2 tests, one that hits Get() and another that hits Get(id). If I place the route before the default route, the second test fails. If I put the route after the default route, the first test fails. – Skadoosh Jan 22 '13 at 19:48
  • Your default route should be the last one because the default route should be the most general. – awj Jan 24 '13 at 11:29