Finally block's content is running before try's content?

Question

How can I fix the below code so that finally part is not overwriten and I can see "This is a regular text" in lbl.Process's Text?

try
{
    grd_Order.SaveClicked(sender, e);
   //This is a button's Clicked event, which redirects to the same page after saving. 
}
catch
{
}
finally
{
   lbl_Process.Text = "This is a regular text"
   //Some more process
}

Edit: Whenever I simplify my code to make my question more understandable, I face the same thing. Many many misunderstandings.

what error are you getting currently? How is it not working? — ayush, Oct 05 '12 at 06:50
Sidenote: instead of calling an event handler `grd_Order.SaveClicked(sender, e)`, call a method `Save` from here and from the click-event handler. — Tim Schmelter, Oct 05 '12 at 06:56
Tim that could be the least useful advice I've seen all day. — Lawrence Johnson, Oct 05 '12 at 06:58
Oh I see now. I was hung up on the difference in names and missed the event-handler / method comparison. — Lawrence Johnson, Oct 05 '12 at 07:05

score 3 · Answer 1 · answered Oct 05 '12 at 06:50

3

The finally block is working, the problem is that since you are redirecting to the same page, your lbl_Error is loosing its Text on postback.

answered Oct 05 '12 at 06:50

Habib

219,104
29
407
436

I have edited the question, can you recheck please. – HOY Oct 05 '12 at 06:59

score 2 · Answer 2 · answered Oct 05 '12 at 06:51

2

If you put a breakpoint in your finally block you will notice that it always executes.

answered Oct 05 '12 at 06:51

Jakub Konecki

45,581
7
87
126

I have edited the question, can you recheck please. – HOY Oct 05 '12 at 07:00

score 1 · Answer 3 · answered Oct 05 '12 at 06:50

There's no purpose for a finally block in the code you posted. Finally is used for cleanup. Move your code to the catch block if its for an error.

Do this:

try
{
    grd_Order.SaveClicked(sender, e);
   //This is a button's Clicked event, which redirects to the same page after saving. 
}
catch (Exception ex)
{
    lbl_Error.Text = "Error Occured " + ex.Message;
}

If the page redirects, that means an error didn't occur.

score 0 · Answer 4 · answered Oct 05 '12 at 06:59

0

FYI:

Try block will execute the code it contains. If any exception is fired runtime, it will be caught by Catch.

And the Finally block will execute anyway.

answered Oct 05 '12 at 06:59

jparthj

1,606
3
20
44

that exact answer was given 7 minutes ago by Jakub. but good thing to reinforce it in case he missed it. – Lawrence Johnson Oct 05 '12 at 06:59
I agree.. but he missed out catch and the questioner was not clear about the fundamental i guess so i explained it ! – jparthj Oct 05 '12 at 07:04

Prabhu Murthy · Answer 5 · 2012-10-05T07:05:52.187

0

Finally always gets executed no matter your application throws exception or not.so you would expect the text to be overwritten

edited Oct 05 '12 at 07:05

answered Oct 05 '12 at 06:59

Prabhu Murthy

9,031
5
29
36

I am not actually tring to catch an exception, I have edited lbl_Error as lbl_Process to prevent missunderstandings. – HOY Oct 05 '12 at 07:02

score 0 · Answer 6 · answered Oct 05 '12 at 07:13

I think your finally code block is working fine. Maybe your lbl text is lost because view state isn't enabled.

I advise you shouldn't write error messages in finally block. Finally block is used for code cleanup etc.

Here you need to put your error message in catch block.

A few more things about try catch finally

Try Block: wrap the code with try block where you are doing stuff (DB retrieval, connections, calling functions etc)

Catch block: The code wrapped in these blocks will be executed when there is an exception in try block, If you want you can have multiple catch blocks each for a specific exception.

Finally: Well finally block always runs regardless of exception or successful execution of try block and this block is used for code cleanup. consider this example - you created a db connection and then try to retrieve some data, you connection is successful but there is an error in your query then there will be an exception and it will come to catch block. what you need to do is to close the connection in finally that way you will not have any open connection.

I hope it will help.

Finally block's content is running before try's content?

6 Answers6