3

I have a custom control (MyControl) that exposes a custom command. I want the parent Window to be able to invoke this command, and all MyControls should react to it.

I have added the command to MyControl's CommandBindings collection, which also provides a CanExecute callback that always returns true.

My problem is that a menu item that invokes this command never gets enabled. I'm presuming this is because the menu is above the MyControls in the visual tree, but to be honest I'm a little fuzzy on how RoutedUICommand's scope works exactly.

Can someone clarify what I'm doing wrong, or if this is even possible?

GazTheDestroyer
  • 20,722
  • 9
  • 70
  • 103

2 Answers2

1

Yes, the point is that the CommandBinding for your custom command is at a lower that your menu item in the visual tree. From msdn

When the CanExecute method on a RoutedCommand is called, the PreviewCanExecute event is raised on the command target. If the event is not handled, the CanExecute event is raised. If the command target has a CommandBinding for the command, the CanExecute handler for that CommandBinding is called. If the command target does not have a CommandBinding for the command, the CanExecute event bubbles up the element tree searching for an element that has a CommandBinding associated with the command.

A very good article about commands in at this link.

Anyway you can use CommandTarget the command from your menu item such as

<MenuItem Header="Click me"  Command="local:CommandClass.MyCustomCommand" CommandTarget="{Binding ElementName=myCustomCtrl}" />

In this way a particular command source (the menu item) directs the command to the specific target (instance of the custom control).

Klaus78
  • 11,648
  • 5
  • 32
  • 28
  • 1
    Unfortunately I need ALL instances of MyControl to respond, not just one, so CommandTarget is no use to me. Have marked your answer because you've confirmed that it's not possible. – GazTheDestroyer Oct 08 '12 at 14:17
1

I guess commands are the wrong mean here.

Commands are used to bundle different command trigger sources to one single command handler. So the command is triggered from different controls, menus, ... but the same command handler is called.

Events are sort of opposit. One source can trigger multiple event handlers.

In your special case I would prefer an event and the the controls below your UI tree would than listen to the tunneling events or the bubbling events.

Rat Baron
  • 11
  • 1