Why isnt location.href() working?

Question

I just want the new page to appear in an iframe on the current page instead of loading a whole new page.

Here's my code:

function salabim(id){
    var gotoo;

    var objid = document.getElementById("pgMaster");

    new Effect.Shake(id);
    return false;

    gotoo=id+".html";
    objid.src=gotoo;
    location.href(gotoo);
}

This doesn't work in any browser. What am I doing wrong?

instructor asked to add the code at the end of the function. so he did... — Binil, Sep 24 '12 at 12:58
As nelson mentioned, everything after return false; is never executed. Put return false; just after your location.href(gotoo); and before the }//end salabim. — akluth, Sep 24 '12 at 14:03

score 4 · Answer 1 · answered Sep 24 '12 at 12:55

4

Move return false; to the end, and use location.href like so:

location.href = gotoo;

answered Sep 24 '12 at 12:55

Danny Beckett

20,529
24
107
134

score 2 · Answer 2 · answered Sep 24 '12 at 12:55

2

location.href is an attribute rather than a function, use location.href = url instead.

answered Sep 24 '12 at 12:55

Marcus

6,701
4
19
28

score 2 · Answer 3 · answered Sep 24 '12 at 12:56

2

I think the correct syntax is:

location.href = gotoo;

answered Sep 24 '12 at 12:56

Tarik

2,151
4
19
26

score 2 · Answer 4 · edited Sep 24 '12 at 13:15

2

You are returning false before you do anything with location.href.

edited Sep 24 '12 at 13:15

Quentin

914,110
126
1,211
1,335

answered Sep 24 '12 at 12:57

Chandra Sekhar Walajapet

2,534
17
24

score 1 · Answer 5 · answered Sep 24 '12 at 12:55

1

You have a return false; in the middle of your function, so code after that return statement isn't executed.

answered Sep 24 '12 at 12:55

kapex

28,903
6
107
121

score 0 · Answer 6 · answered Sep 24 '12 at 13:10

0

use

window.location.href = "YourURL";

answered Sep 24 '12 at 13:10

V.J.

9,492
4
33
49

Why isnt location.href() working?

6 Answers6