Can't get mysql_insert_id() to work

Question

I tried this:

$cid = mysql_insert_id($this->result);
$this->result = "<div class='alert alert-success'>" . sprintf(_('Successfully added user id <b>%s</b> to the database.'), $cid) . "</div>";

but I only get this error:

Warning: mysql_insert_id(): supplied argument is not a valid MySQL-Link resource in

This is the entire function (i added this $cid = mysql_insert_id($this->result); hoping to retrieve the id of the inserted data):

private function adduser() {

    if (!empty($this->error)) return false;

    $params = array(
        ':user_level' => parent::getOption('default-level'),
        ':name'       => $this->name,
        ':email'      => $this->email,
        ':username'   => $this->username,
        ':password'   => parent::hashPassword($this->password)
    );

    parent::query("INSERT INTO `login_users` (`user_level`, `name`, `email`, `username`, `password`)
                    VALUES (:user_level, :name, :email, :username, :password);", $params);

    $shortcodes = array(
        'site_address'  =>  SITE_PATH,
        'full_name'     =>  $this->name,
        'username'      =>  $this->username,
        'email'         =>  $this->email,
        'password'      =>  $this->password
    );

    $subj = parent::getOption('email-add-user-subj');
    $msg = parent::getOption('email-add-user-msg');

    if(!parent::sendEmail($this->email, $subj, $msg, $shortcodes))
        $this->error = _('ERROR. Mail not sent');
    $cid = mysql_insert_id($this->result);
    $this->result = "<div class='alert alert-success'>" . sprintf(_('Successfully added user <b>%s</b> to the database. Credentials sent to user.'), $cid) . "</div>";

}

This is the connection to the database:

<?php
$host = "xxx"; 
$dbName = "xxx"; 
$dbUser = "xxx"; 
$dbPass = "xxx"; 
?>

We would need to see a few preceeding lines - especially as at the end you set $this->result to text — BugFinder, Sep 19 '12 at 07:24
Where's your query and designated result? Please updat with some more lines of code. First off, using `this->result` as the result identifier and then using it to set a string doesn't seem correct. — bartvanraaij, Sep 19 '12 at 07:25

score 2 · Answer 1 · answered Sep 19 '12 at 07:26

2

mysql_insert_id() takes a resource link, i.e. database handle, as an argument not the query result. What does $this->result contain?

answered Sep 19 '12 at 07:26

mbfisher

306
3
7

score 1 · Answer 2 · answered Sep 19 '12 at 07:28

1

Check Manual

Parameter for mysql_insert_id is Link_Identifier. But I guess you are passing result. Try

$cid = mysql_insert_id();

or your $this->result must be connection identifier returned by mysql_connect().

answered Sep 19 '12 at 07:28

Kapil Sharma

10,135
8
37
66

Resulted in: Warning: mysql_insert_id() [function.mysql-insert-id]: A link to the server could not be established in – Dreni Sep 19 '12 at 07:31

Mihai Iorga · Answer 3 · 2012-09-19T19:26:51.323

0

You are already using PDO, switch to:

$cid = self::$dbh->lastInsertId(); // PDO for mysql_insert_id

edited Sep 19 '12 at 19:26

answered Sep 19 '12 at 07:33

Mihai Iorga

39,330
16
106
107

I got this error: Fatal error: Call to undefined method Generic::lastInsertId() in – Dreni Sep 19 '12 at 07:36
It means your parent hasn't that function. Aren't you using PDO? – Mihai Iorga Sep 19 '12 at 07:37
Yes, so how do I add this function to my parent? – Dreni Sep 19 '12 at 07:40
I don't know how your parent it's constructed .. Please post your parent's `query` function – Mihai Iorga Sep 19 '12 at 07:41

Can't get mysql_insert_id() to work

3 Answers3

Linked

Related