No such file or directory: open-uri in rails controller

Question

I am trying to use open method of open-uri gem in Rails.

When I try it in standalone Ruby application I just require it on top of the file and everything is ok. But now I want it to use it controller in Rails app. Is it advisable to put require on top of controller?

Controller code:

def search
  if params.has_key? :q
    params[:q] =~ /\?v=(.*?)&/
    xmlfeed = Nokogiri::XML(open("http://gdata.youtube.com/feeds/api/videos?q=#{$1}"))
    if xmlfeed.at_xpath("//openSearch:totalResults").content.to_i == 1
      flash[:notification] = "Video #{xmlfeed} found"
      #save video id to database
      redirect_to root_url
    else
      flash[:error] = "Video #{xmlfeed} not found"
      redirect_to root_url
    end
  else
    flash[:error] = "You didn't insert video URL."
    redirect_to root_url
  end
end

Error:

No such file or directory - http://gdata.youtube.com/feeds/api/videos?q=cSnkWzZ7ZAA

score 1 · Answer 1 · answered Sep 13 '12 at 08:34

1

I think that a better practice is to create a model for fetching youtube feeds and put all code that fetches the videos and parses the result in there - the controller should be as thin as possible.

answered Sep 13 '12 at 08:34

EfratBlaier

559
2
6

score 1 · Answer 2 · answered Sep 26 '12 at 15:14

You should make a model for this kinda stuff.

But answering directly to you question. You will not really feel any difference when putting it at the top of the controller or in the action you need it.

Maybe high intensive apps might notice it when benchmarking but I haven't seen it yet.

No such file or directory: open-uri in rails controller

2 Answers2