Update a count variable in model object

Question

What I want to do is simple I want to update the count variable of the object every time my view function is called.

My models is like this:

class Url(models.Model):
      #some vars here
      count=0

      def __unicode__(self):
            return self.urlx
      def incr(self):
            self.count+=1

and my view code is like this

@transaction.autocommit
def redirect(request,key):
    if(key):
        key='/'+key
        try:
            ob=Url.objects.get(urlx=key)
            ob.incr()  #not working
            ob.save()  #not working
            return HttpResponseRedirect(ob.url)
            val=ob.count
        except Url.DoesNotExist:
            key="Sorry! couldn't find that url"         

    return render_to_response('redir.html',{},context_instance=RequestContext(request))

I am sure I am overlooking something here, or is this not the correct way to do this?

You might also want to look at some code basics, after returning a value from a function no code is executed passed that point so val=ob.count is useless — Hedde van der Heide, Sep 02 '12 at 10:17
@Hedde : sorry...i left it there...i was testing the try block earlier.. — Dhiraj Thakur, Sep 02 '12 at 10:19

score 3 · Accepted Answer · answered Sep 02 '12 at 10:12

Since you've missed out the "other vars here", it's not clear if you realize that Django model fields need to be, well, fields - that is, models.CharField, models.IntegerField, etc. Putting count=0 just makes a class variable that won't be persisted in the database. You probably just want count = models.IntegerField(default=0).

Update a count variable in model object

1 Answers1