What does this function do and How to rewrite without the 'with' statement - Javascript

Question

Javascript:

function ValidDate(y, m, d)
{ // m = 0..11 ; y m d integers, y!=0
  with (new Date(y, m, d))
    return (getMonth()==m && getDate()==d); /* was y, m */
}

score 4 · Accepted Answer · edited Aug 28 '12 at 16:46

4

Simple:

function ValidDate(y, m, d) {
  var date = new Date(y, m, d);
  return date.getMonth() == m && date.getDate() == d;
}

edited Aug 28 '12 at 16:46

Naftali

144,921
39
244
303

answered Aug 28 '12 at 16:40

Tomasz Nurkiewicz

334,321
69
703
674

var date = new Date(y, m, d)) should be var date = new Date(y, m, d); I believe otherwise this works. – Joshua Fricke Aug 28 '12 at 16:43
@JoshuaFricke: thanks for edit, C&P error. +1 for your answer as well :-). – Tomasz Nurkiewicz Aug 28 '12 at 16:48

score 3 · Answer 2 · answered Aug 28 '12 at 16:40

with makes it so that the this scope is the statement in the with so you don't have to do any .functionName(...)

What you can do:

function ValidDate(y, m, d)
{ // m = 0..11 ; y m d integers, y!=0
    var date = new Date(y, m, d);
    return (date.getMonth()==m && date.getDate()==d); /* was y, m */
}

What does this function do and How to rewrite without the 'with' statement - Javascript

2 Answers2