Nokogiri fails outputting XML with UTF-16 declaration (understanding and working around)

Question

Summary

Attempting to read and serialize XML documents that have a UTF-16 encoding and declaration causes Nokogiri to produce garbage after a certain point.

Is this a bug, or is there a reasonable explanation for this?
What's the best way to avoid it?

Environment

C:\>nokogiri -v
# Nokogiri (1.5.5)
    ---
    warnings: []
    nokogiri: 1.5.5
    ruby:
      version: 1.9.3
      platform: i386-mingw32
      description: ruby 1.9.3p194 (2012-04-20) [i386-mingw32]
      engine: ruby
    libxml:
      binding: extension
      compiled: 2.7.7
      loaded: 2.7.7

Details

I have an XML file encoded with UTF-16(LE), and it also includes a PI XML Declaration at the top indicating that the encoding is UTF-16. Summarized, it looks like this:

<?xml version="1.0" encoding="UTF-16" ?>
<Foo>
  <Bar><![CDATA[
Lorem ipsum dolor ...about 3900 more bytes of content here...
  ]]></Bar>
  <Jim>Oh! Hello there.</Jim>
</Foo>

When I use Nokogiri to read this document, all seems well:

xml = File.open('Simplified.xml','rb:utf-16le',&:read)
p xml.encoding                        # #<Encoding:UTF-16LE>
p xml.valid_encoding?                 # true
doc1 = Nokogiri.XML(xml,&:noblanks)
xml1 = doc1.to_xml.encode('utf-8')
p xml1.encoding                       # #<Encoding:UTF-8>
p xml1.valid_encoding?                # true

However, the output of serializing the document becomes munged after a certain point:

p xml1  # Correct contents of CDATA removed from the following output
#=> "<?xml version=\"1.0\" encoding=\"UTF-16\"?>\n<Foo>\n  <Bar><![CDATA[\n...\n\t]]></Bar>\n  <Jim>Oh! Hello there.\uFFFE\u3C00\u0000\u2F00\u0000\u4A00\u0000\u6900\u0000\u6D00\u0000\u3E00\u0000\u0A00\u0000\u3C00\u0000\u2F00\u0000\u4600\u0000\u6F00\u0000\u6F00\u0000\u3E00\u0000\u0A00\u0000"

_{(The limit seems to be related to the number of characters. I can add and remove a few words from the Lorem ipsum text with no change, but removing text below a certain point suddenly fixes the output.)}

The Nokogiri document is not broken, however. I can independently serialize <Jim> successfully:

puts doc1.at('Jim').to_xml.encode('utf-8')
#=> <Jim>Oh! Hello there.</Jim>

The only workaround I've found is to remove the XML Declaration at the top of the document before parsing it. With this, all works as desired:

decl = '<?xml version="1.0" encoding="UTF-16" ?>'.encode('UTF-16LE')
doc2 = Nokogiri.XML(xml.sub(decl,''),&:noblanks)
puts doc2.to_xml.encode('utf-8')
#=> <?xml version="1.0"?>
#=> <Foo>
#=>   <Bar><![CDATA[
#=> Lorem ipsum dolor...and more...
#=>   ]]></Bar>
#=>   <Jim>Oh! Hello there.</Jim>
#=> </Foo>

Full XML

Here's the full file to test for yourself:

<?xml version="1.0" encoding="UTF-16" ?>
<Foo>
  <Bar><![CDATA[
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Etiam ac augue arcu, eget laoreet lorem. Quisque ac augue velit. Integer consectetur suscipit vehicula. Etiam et convallis enim. Etiam varius massa sit amet lacus rhoncus varius in non ante. Sed dictum, metus eu bibendum ornare, ligula dui commodo urna, ut dignissim felis dolor eget nisl. Proin sit amet nisi nunc. Vestibulum a urna sed dui dignissim blandit nec vel enim. Vivamus tincidunt nulla id dui hendrerit hendrerit.
Aliquam neque orci, luctus sit amet fringilla eu, varius vitae diam. Suspendisse varius rutrum lorem eget malesuada. Sed dapibus dapibus nisl, in cursus ante lacinia non. Aenean id sagittis ipsum. Suspendisse elit nunc, porta sit amet blandit ut, laoreet sed est. Nunc eget sem vitae nisl elementum ullamcorper ut sit amet urna. Sed ligula quam, fringilla in facilisis tincidunt, vehicula in nisi. Maecenas a augue in augue semper scelerisque sit amet ut arcu.
Praesent hendrerit, enim in elementum ornare, lorem nisi euismod dolor, sit amet ornare mi sem sodales lacus. Fusce et tempor mauris. In non quam nisl, non consequat diam. Duis sit amet massa ultrices massa cursus iaculis. Nunc ullamcorper malesuada sem dignissim semper. Fusce aliquet lacus quis nisi tincidunt sodales. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque posuere commodo aliquet. Aliquam blandit vestibulum facilisis. Sed pellentesque viverra dignissim. Etiam est lacus, mollis eu pretium vitae, lacinia eleifend augue. Mauris vitae quam nisl. In venenatis nunc ac eros elementum cursus.
Sed a metus sit amet nunc euismod condimentum id non orci. Curabitur velit turpis, lacinia non eleifend sed, rhoncus id est. Fusce ut massa dolor, ut sodales odio. Donec aliquam convallis tellus, eu pharetra tortor iaculis non. Integer imperdiet feugiat ipsum a gravida. Mauris sapien ipsum, ultricies ac placerat ut, imperdiet eu justo. Quisque quis consectetur velit. Etiam facilisis sapien nec enim tincidunt pulvinar. Duis fermentum faucibus felis, sed consequat libero pretium at. Phasellus nibh purus, suscipit in vestibulum vel, blandit at leo. Suspendisse placerat elit sed enim bibendum vel hendrerit mauris pretium. Maecenas ut lacus eu nisi euismod pretium.
Aliquam feugiat felis id massa aliquam pharetra sed non eros. Morbi interdum molestie iaculis. Curabitur varius ante ac dui dapibus non laoreet risus blandit. Nunc sit amet magna lacus. Vestibulum ante ipsum primis in faucibus orci luctus et ultrices posuere cubilia Curae; Phasellus egestas nunc sed turpis imperdiet a rhoncus massa aliquam. Nulla facilisi. Phasellus sit amet neque felis, nec vestibulum massa. Donec luctus fringilla dolor et gravida. Phasellus euismod lectus eget elit hendrerit non vehicula tellus venenatis. Phasellus sit amet ligula et purus dignissim feugiat at vitae libero. Proin ut tortor eros, quis laoreet lectus. Quisque nec urna mattis ante gravida fermentum eu at nibh. Phasellus sapien elit, tincidunt quis laoreet id, lobortis sed magna. Aliquam pulvinar erat eu sapien pretium bibendum. Maecenas eleifend, leo quis sodales tincidunt, leo felis tristique dolor, vitae ultrices neque felis ut metus.
Etiam dignissim egestas ipsum, eget tempor ipsum rutrum eu. Donec vehicula eleifend ullamcorper. Mauris justo nulla, varius a mattis a, cursus sit amet risus. Phasellus rutrum interdum blandit. Donec ut justo eros, ut auctor dolor. Suspendisse potenti. Cras ultricies, dui eget mattis bibendum, leo dui luctus purus, sit amet rhoncus libero metus eget purus. Pellentesque scelerisque ornare sapien faucibus tempor.
Suspendisse potenti. Proin fermentum bibendum dapibus. Pellentesque facilisis aliquam. Nam egestas tellus non mauris scelerisque feugiat pellentesque lacus dignissim. Quisque id nulla felis. Mauris justo mauris, posuere sed facilisis in, venenatis nec risus. Mauris eu dui sed tellus laoreet tempor a in turpis volutpat.
  ]]></Bar>
  <Jim>Oh! Hello there.</Jim>
</Foo>

On the assumption that this is a bug, I've filed [a bug report](https://github.com/sparklemotion/nokogiri/issues/752). — Phrogz, Aug 28 '12 at 15:59
"it also includes a PI at the top indicating that the encoding is UTF-16." I assume you mean it's a BOM, right? `\uFFFE` is a BOM but doesn't specify the length of the characters. Looking at the following bytes in the inspect, make me think you're dealing with UTF-32LE, not 16, because we can't entirely trust the `encoding=` statement, but, that might be the result of the libxml or Nokogiri code, not the file itself. Try `od` to look at the characters and bytes in the file, and specifically in the area of the problem. Is there anything odd in the file at that position? — the Tin Man, Aug 28 '12 at 16:43
You might triangulate the problem with http://stackoverflow.com/questions/12085250/nokogiri-producing-different-results-on-heroku. Sounds like it might be a similar issue. — the Tin Man, Aug 28 '12 at 16:47
@theTinMan The file is encoded on disk as UTF-16LE with BOM, and (as seen above) the first line of the file has ``. It is the presence of this first-line processing instruction that causes the problem with Nokogiri's serialization. — Phrogz, Aug 28 '12 at 20:47
The first bytes of the file hex dumped are: `FF FE 3C 00 3F 00 78 00 6D 00 6C 00 20 00 76 00`; we see [the two-byte BOM](http://unicode.org/faq/utf_bom.html#bom4) followed by a series of two-byte characters, where the second byte of these ASCII characters is null. This helps confirm that the UTF-16LE encoding is valid. — Phrogz, Aug 28 '12 at 20:55
I ran into a bunch of mis-coded XML in the past and became wary of trusting the `encoding=` parameter. The byte values in the file are the authority, and I agree, it's UTF-16LE. Sounds like a bug in either Nokogiri or libXML. — the Tin Man, Aug 28 '12 at 21:01

score 3 · Accepted Answer · answered Sep 05 '12 at 18:19

Rather than serialising the xml then calling encode on the string, you can specify the encoding to use in the options to to_xml; instead of

xml1 = doc1.to_xml.encode('utf-8')

use:

xml1 = doc1.to_xml(:encoding => 'utf-8')

This seems to clear up the problems.

As for what’s going on, I can only offer some observations.

Firstly, the encoding of the string produced by to_xml without specifying the encoding is UTF-16, which in Ruby is a “dummy encoding” (whatever that means):

xml1 = doc1.to_xml
p xml1.encoding
#=> #<Encoding:UTF-16 (dummy)>

The docs say this about dummy encodings:

A dummy encoding is an encoding for which character handling is not properly implemented. It is used for stateful encodings.

The other thing I noticed is that the values in the munged part of the output actually correspond to the codepoints that should appear.

Hello there.\uFFFE\u3C00\u0000\u2F00\u0000\u4A00\u0000\u6900...

3C is <, 2F is /, 4A is J, 69 is i etc, producing (if you ignore the zeros and extra BOM)

Hello there.</Ji...

If you write out the XML produced by Nokogiri before encoding to UTF-8) and point a hex editor at it, the start looks like this:

0000000 ff fe 3c 00 3f 00 78 00 6d 00 6c 00 20 00 76 00

It starts with FF FE, i.e. a little endian BOM.

At the point the munging starts, it looks like this:

0001f20 3c 00 4a 00 69 00 6d 00 3e 00 4f 00 68 00 21 00
0001f30 20 00 48 00 65 00 6c 00 6c 00 6f 00 20 00 74 00
0001f40 68 00 65 00 72 00 65 00 2e 00 fe ff 00 3c 00 00
0001f50 00 2f 00 00 00 4a 00 00 00 69 00 00 00 6d 00 00
0001f60 00 3e 00 00 00 0a 00 00 00 3c 00 00 00 2f 00 00

fe ff is where the munged output starts (on the middle line). fe ff is also the big endian BOM, and the other characters seem to be BE (you can see how the columns of zeros don’t line up before and after the fe ff. There are extra pairs of zero bytes in between the characters though.

Nokogiri fails outputting XML with UTF-16 declaration (understanding and working around)

Summary

Environment

Details

Full XML

1 Answers1