10

I have the following code snippet / example. It's not working code I just wrote this so as to ask a question about catch, finally and return:

try
{
    doSomething();
}
catch (Exception e)
{
    log(e);
    return Content("There was an exception");
}
finally
{
    Stopwatch.Stop();
}
if (vm.Detail.Any())
{
    return PartialView("QuestionDetails", vm);
}
else
{
    return Content("No records found");
}

From what I understand if there's an exception in the try block it will go to catch. However if there is a return statement in the catch then will the finally be executed? Is this the correct way to code a catch and finally ?

MAXE
  • 4,978
  • 2
  • 45
  • 61
Angela
  • 3,269
  • 3
  • 22
  • 24

5 Answers5

14

Within a handled exception, the associated finally block is guaranteed to be run. However, if the exception is unhandled, execution of the finally block is dependent on how the exception unwind operation is triggered. That, in turn, is dependent on how your computer is set up. For more information, see Unhandled Exception Processing in the CLR.

Ref: Try-Finally

Mitch Wheat
  • 295,962
  • 43
  • 465
  • 541
10

Yes the finally will get executed, even if you return something before.

The finally block is useful for cleaning up any resources that are allocated in the try block, and for running any code that must execute even if an exception occurs in the try block. Typically, the statements of a finally block are executed when control leaves a try statement, whether the transfer of control occurs as a result of normal execution, of execution of a break, continue, goto, or return statement, or of propagation of an exception out of the try statement.

More Information

MSDN - try-finally (C# Reference)

dknaack
  • 60,192
  • 27
  • 155
  • 202
4

The finally will be executed even if there is a return within the catch block

finally block is always executed

Massimiliano Peluso
  • 26,379
  • 6
  • 61
  • 70
3

The finally will execute after the catch-block is exited (in your by means of an explicit "return"). However, everything after the finally-block (in your case the if (vm.Detail.Any()) ...) will not execute.

Christian.K
  • 47,778
  • 10
  • 99
  • 143
2

The code in the finally block will run despite the return statement in your catch block. However, I personally would assign the result to a variable and return it after the block. But that's just a matter of taste.

geratri
  • 111
  • 5