How can I accept strings like "$1,250.00" and convert it to a decimal in C#?

Question

Do I just do a replace("$", "") and (",", "") or is there a different way I should handle this kind of input?

score 20 · Accepted Answer · edited Aug 26 '09 at 18:21

20

Have you tried Decimal.Parse with the AllowCurrencySymbol option (and other supporting options)?

var d = Decimal.Parse(input, 
  NumberStyles.AllowCurrencySymbol |
  NumberStyles.AllowDecimalPoint |
  NumberStyles.AllowThousands);

edited Aug 26 '09 at 18:21

tvanfosson

524,688
99
697
795

answered Jul 31 '09 at 03:34

JaredPar

733,204
149
1,241
1,454

Luke Schafer · Answer 2 · 2009-07-31T03:40:53.890

5

now with formatting :)

decimal val = Decimal.Parse(
    Value.Replace(" ", ""), 
    NumberStyles.AllowThousands 
     | NumberStyles.AllowDecimalPoint 
     | NumberStyles.AllowCurrencySymbol
);

http://www.codeproject.com/KB/cs/Eduardo_Sierra.aspx

edited Jul 31 '09 at 03:40

answered Jul 31 '09 at 03:33

Luke Schafer

9,209
2
28
29

May I ask why you're replacing spaces with empties instead of trimming them? – Steven Sudit Jul 31 '09 at 04:48
I listed the url for the site I grabbed the code off, I didn't write it myself (why spend a couple of minutes reinventing wheels when a 15 second google gets the answer?). The example given on the site is for when someone has placed a space after the currency symbol – Luke Schafer Jul 31 '09 at 06:00
Yep. You only need to add NumberStyles.AllowLeadingWhite | NumberStyles.AllowTrailingWhite instead of doing the string replacement. Arguably, removing whitespace in the middle would be incorrect since it would potentially validate something that isn't correct. – tvanfosson Aug 26 '09 at 18:23

score 5 · Answer 3 · answered Jul 31 '09 at 03:35

Do I just do a Replace("$", "") and Replace(",", "")[?]

No. For one, code like this is not fun to maintain. Secondly, '$' is not the only currency symbol in the world, and ',' is not the only thousands separtor. That is, code like you're thinking makes globalization issues difficult.

[I]s there a different way I should handle this kind of input?

Yes. Use Decimal.Parse with NumberStyles.Currency:

string s = "$1,250.00";
decimal d = decimal.Parse(s, NumberStyles.Currency);

score -2 · Answer 4 · answered Jul 31 '09 at 03:39

-2

This should do the trick:


      string money = "$1,250.00";
      money = money.Replace('$',' ');
      decimal test = Convert.ToDecimal(money);

answered Jul 31 '09 at 03:39

Freddy

3,064
3
26
27

How can I accept strings like "$1,250.00" and convert it to a decimal in C#?

4 Answers4