How convert string (masked) to decimal?

Question

I have mask in textbox "99:99" I need convert to decimal. example: string "12:34" converted to 12.34

I create method:

private decimal ConvertStringMaskToDecimal(string strMask)
{
    var split = strMask.Split(':');
    if(split.Length==2)
    {
        decimal returnValue = decimal.Parse(split[0]) + decimal.Parse(split[1])/100;
        return returnValue;
    }
    else
    {
        throw new ArgumentException("strMask not valid");
    }
}

this code is worked but I think the code is not correct, how to solve this problem

Konrad Morawski · Answer 1 · 2012-08-21T09:41:03.297

3

As I remarked in my comment to Oded's answer: hardcoding a dot as a decimal separator is not recommended.

This picture explains why.

I suggest:

using System.Globalization;

// (...)
decimal.Parse(strMask.Replace(":", CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator));

instead.

Or, as Henk Holterman suggested:

decimal.Parse(strMask.Replace(':', '.'), CultureInfo.InvariantCulture);

To the same effect (not crashing on non-American machines).

edited Aug 21 '12 at 09:41

answered Aug 21 '12 at 09:33

Konrad Morawski

8,307
7
53
91

1

Might as well use: `decimal.Parse(..., CultureInfo.InvariantCulture)` – H H Aug 21 '12 at 09:36
@HenkHolterman you're right. I updated my answer accordingly. – Konrad Morawski Aug 21 '12 at 09:38

Oded · Accepted Answer · 2012-08-21T10:09:53.227

1

Just replace the : with . before parsing:

decimal.Parse(strMask.Replace(':', '.'), CultureInfo.InvariantCulture)

Note the use of CultureInfo.InvariantCulture to ensure that the . is interpreted correctly.

edited Aug 21 '12 at 10:09

answered Aug 21 '12 at 09:20

Oded

489,969
99
883
1,009

1

Hardcoding a dot as a decimal separator is not a good practice. http://en.wikipedia.org/wiki/File:DecimalSeparator.svg – Konrad Morawski Aug 21 '12 at 09:26
@Konrad Morawski, how do this? – Mediator Aug 21 '12 at 09:28

V4Vendetta · Answer 3 · 2012-08-21T09:35:35.760

-1

you can use decimal.Parse after replacing colon : with the decimal point .

decimal.Parse(strMask.Replace(':', '.'), CultureInfo.InvariantCulture)

edited Aug 21 '12 at 09:35

answered Aug 21 '12 at 09:22

V4Vendetta

37,194
9
78
82

How convert string (masked) to decimal?

3 Answers3