Nested condition vs. return on unexpected result

Question

Consider the two following coding-styles:

Nested conditions:

if(is_numeric($user_id)) {

    // .. do stuff
    if(is_valid_user($user_id)) {
        return foo($user_id);
    } else {
        return FALSE;
    }

} else {
    return FALSE;
}

vs. just simply stopping when something is wrong:

if(!is_numeric($user_id)) {
    return FALSE;
}    

// .. do stuff

if(!is_valid_user($user_id)) {
    return FALSE;
}

return foo($user_id);

This is of course at least partially about taste; but what are these two different styles called?

When are one prefered over the other?

Are there other, perhaps cleaner, coding styles?

Steve Robbins · Answer 1 · 2012-08-10T00:00:39.200

1

You could leave off the elses entirely.

if (is_numeric($user_id)) {

    // do stuff

    if (is_valid_user($user_id))    
        return foo($user_id);
}

return false;

A bit cleaner, less code, still easy to read/understand.

edited Aug 10 '12 at 00:00

answered Aug 09 '12 at 23:37

Steve Robbins

13,672
12
76
124

but there is code between the is_numeric check and the is_valid_user check – hackattack Aug 09 '12 at 23:50
@hackattack That isn't mentioned in the question – Steve Robbins Aug 09 '12 at 23:52
No? ... I got that impressions from the "// .. do stuff" comment between the 2 if statements – hackattack Aug 09 '12 at 23:57

score 1 · Answer 2 · answered Aug 09 '12 at 23:42

Another coding style related to your question is only having one return statement per method/function.

Schools often teach this principle. I think that Martin Fowler was a proponent of this originally based on some online searches.

The major reason is probably irrelevant to PHP, but in C for example, if you had dynamically allocated memory in the function that needs to be cleaned up, having returns all over the place either leads to repeated code, leaked memory, or having to use goto to get to the code for freeing memory.

score 1 · Accepted Answer · answered Aug 09 '12 at 23:55

I generally go by the idea that the least nesting the easier something is to read. I prefer the second style for that reason. Of course it doesn't matter what style you use, I would even change your second example slightly to make things even easier for me to read.

if(!is_numeric($user_id)) return FALSE;

// .. do stuff

if(!is_valid_user($user_id)) return FALSE;

return foo($user_id);

To me having the return statements on the right makes them stand out. Also, having the whole thing on one line helps me picture the statements being gates and easily spilts the code into sections ... but that is just me.

Nested condition vs. return on unexpected result

3 Answers3