Null pointer exception in getView() of custom Adapter

Question

I am using this Custom Adapter for my ListView:

public class SideMenuAdapter extends BaseAdapter {

    private static final int TYPE_MAX_COUNT = 2;
    private static LayoutInflater inflater = null;
    private Activity activity;
    public static String[] values;
    ListView myList;

    public SideMenuAdapter(Activity a, String[] sa, ListView lv) {

        values = sa;
        activity = a;
        inflater = (LayoutInflater) activity
                .getSystemService(Context.LAYOUT_INFLATER_SERVICE);
        myList = lv;
    }

    public int getCount() {

        return values.length;
    }

    public Object getItem(int position) {

        return position;
    }

    public long getItemId(int position) {

        return position;
    }

    public static class ViewHolder {

        public TextView mainText;
        public TextView sideText;
    }

    public View getView(int position, View convertView, ViewGroup parent) {

        ViewHolder holder = new ViewHolder();
        View vi = convertView;
        if (vi == null) {

            //here i am getting NullPointerException
            vi.setTag(holder);
        } else {

            holder = (ViewHolder) vi.getTag();
        }
        vi = inflater.inflate(R.layout.side_menu_list_item, null);
        holder.mainText = (TextView) vi.findViewById(R.id.mainText_sideMenu);
        holder.sideText = (TextView) vi.findViewById(R.id.sideText_sideMenu);
        holder.mainText.setText(values[position]);
        if(position == 2){

            holder.sideText.setText("3");
            holder.sideText.setBackgroundResource(R.drawable.orange);
        }
        return convertView;
    }
    @Override
    public int getViewTypeCount() {

        return TYPE_MAX_COUNT;
    }
}

i am setting adapter to my listview this way:

    String menuItems[] = new String[] { "My Wants", "Profile", "Notifications",
            "Feedback", "Logout" };
    listView1.setAdapter(new SideMenuAdapter(this, menuItems, listView1));

where am i wrong??

score 3 · Accepted Answer · answered Aug 03 '12 at 08:39

3

You should initialize vi before your vi.setTag(holder);

answered Aug 03 '12 at 08:39

Saasha

277
1
2
8

to the layout i am using for ListView Items?? – Archie.bpgc Aug 03 '12 at 08:42
Yes. Here is example of using custom BaseAdapter http://thinkandroid.wordpress.com/2010/01/13/custom-baseadapters/ – Saasha Aug 03 '12 at 08:46

score 3 · Answer 2 · edited Apr 08 '20 at 19:35

Try this, might help u...

public View getView(int position, @Nullable View convertView, ViewGroup parent) {

    ViewHolder holder = new ViewHolder();
    View vi = convertView;
    if (vi == null) {
        LayoutInflater inflater = ((Activity)activity).getLayoutInflater();
        vi = inflater.inflate(R.layout.side_menu_list_item, null);
        holder.mainText = (TextView) vi.findViewById(R.id.mainText_sideMenu);
        holder.sideText = (TextView) vi.findViewById(R.id.sideText_sideMenu);
        vi.setTag(holder);
    } else {

        holder = (ViewHolder) vi.getTag();
    }

    holder.mainText.setText(values[position]);
    if(position == 2){

        holder.sideText.setText("3");
        holder.sideText.setBackgroundResource(R.drawable.orange);
    }
    return convertView;
}

yay... :) this help me: http://stackoverflow.com/questions/12590342/nullpointer-exception-by-findviewbyid-in-android — user568021, Dec 04 '13 at 05:21

Null pointer exception in getView() of custom Adapter

2 Answers2

Linked