3d array allocation by void function

Question

I obtain a Segmentation Fault when i=0 and j=2; But I don't know why !

Could you help me ?

That's my function :

void allocationdynamiquetableautroisdimdentier(int**** Matrice,int nbniveau, int nbligne, int nbcolonne)
{
int i,j;
    *Matrice=(int***) malloc (sizeof(int**)*nbniveau);
    for (i=0; i<nbniveau; i++)
    {
        (*(Matrice))[i]=(int**) malloc (sizeof(int*)*nbligne);  // allocation dynamique de la matrice Matrice
        for (j=0; j<nbligne; i++)
        {
            ((*(Matrice))[i])[j]=(int*) malloc (sizeof(int)*nbcolonne);
        } 
    }

}

There are certainly more efficient ways to implement this, and there are way too many unnecessary parentheses but I can't see why it would fault unless malloc is returning NULL. — ams, Jul 23 '12 at 16:12
It might be more reasonable to allocate a flat array and have helper functions for translating between (i,j,k) to a flat index, and back. — AlcoJaguar, Jul 23 '12 at 18:44

score 3 · Accepted Answer · answered Jul 23 '12 at 16:13

3

        for (j=0; j<nbligne; i++)

should be

        for (j=0; j<nbligne; j++)

answered Jul 23 '12 at 16:13

ecatmur

152,476
27
293
366

score 2 · Answer 2 · answered Jul 23 '12 at 16:13

2

You have i++ in both loop statements!

answered Jul 23 '12 at 16:13

ams

24,923
4
54
75

3d array allocation by void function

2 Answers2