Android setText / R.string / values

Question

I am having trouble with setting text in a text view with format and multiple values.

holder.car.setText(R.string.mycar + lm.getCarName() + R.string.year + lm.getYear());

this is giving me " 2143545 Camero 2143213 1977 "

I have tried few other "solutions" from the web

holder.car.setText(getString(R.string.mycar) + lm.getCarName() + getString(R.string.year) + lm.getYear());  << not work, getString undefine>>

I even tried String.valueOf(R.string.mycar); getResources().getText(R.String.mycar), still it didn't work.

It would be great if someone can help me, thanks

It's because `R.string.mycar` is an `int` that refers to a resource. It's not the actual resource. @user1417127 's answer looks good. It fetches the actual string resource for you — Mike T, Jul 18 '12 at 07:32

score 26 · Answer 1 · edited Apr 15 '15 at 11:29

26

Try this

holder.car.setText(getResources().getString(R.string.mycar));

edited Apr 15 '15 at 11:29

Alexander Zhak

9,140
4
46
72

answered Jul 18 '12 at 07:30

user1417127

1,525
1
21
29

score 14 · Answer 2 · answered Jul 18 '12 at 08:04

I think you're trying to use parameters in your string.

Try this:

<string name="mycar">Car: %1$s Year: %2$s</string>

String mycar = getString(R.string.mycar);
mycar = String.format(mycar, lm.getCarName(), lm.getYear());

You should get:

Car: Camaro Year: 1977

score 6 · Answer 3 · answered Sep 06 '16 at 10:48

6

If you want to set your textview just a string from your string.xml file,

mytextview.setText(R.String.mycar);

If you want to set your textview with combination of some strings or integers, (better than first way)

int number=5;

mytextview.setText(getResources().getString(R.String.mycar) + " " +number + " " + getResources().getString(R.String.mysecondcar));

answered Sep 06 '16 at 10:48

Gökhan Sarıkaya

71
1
3

How to deal with the Android Studio warning: "Do no concanate text displayed with setText. Use Resource string with place holders" ? – mparkes Sep 09 '18 at 04:39

score 4 · Answer 4 · answered Jul 18 '12 at 07:35

R.string.mycar and R.string.year are only IDs for resources. For this reason you get the numbers (IDs are numeric).

To get string from resources you need to use this construction:

String myCar = getResources().getString(R.string.mycar);

and now the myCar variable holds the string you put in strings.xml file under the mycar name.

the method getResources() belongs to Context. If you run your code outside an Activity, use the context instance to get the string, like this:

String myCar = context.getResources().getString(R.string.mycar);

score 3 · Answer 5 · answered Jul 18 '12 at 07:34

3

Try this. If you're fetching string in class without extending Activity Get using your Context

holder.car.setText(context.getResources().getString(R.string.mycar));

If you're extending Activity

holder.car.setText(yourActivity.this.getResources().getString(R.string.mycar));

Hope this helps you..

answered Jul 18 '12 at 07:34

Praveenkumar

24,084
23
95
173

instead of `context` can we write `getActivit()` ? are there any problem – mehmet May 08 '14 at 15:11
@mehmet It depends on your requirement. Read the [document here](http://developer.android.com/reference/android/app/Fragment.html#getActivity()) – Praveenkumar May 09 '14 at 04:45

score 2 · Answer 6 · answered Jul 18 '12 at 07:30

2

You have to retrieve your resources first, and the call the medthod getString(int), not getText, has you have put.

So, it should be:

getResources().getString(R.String.mycar);

answered Jul 18 '12 at 07:30

Iñigo

12,723
2
31
31

score 0 · Answer 7 · answered Jul 18 '12 at 08:03

0

The R class contains kind of pointers to your ressources, so you can not directly use them, use getResources().getString(), as others say.

answered Jul 18 '12 at 08:03

Rocel

1,029
1
7
22

Rasheed Al-Wahbany · Answer 8 · 2023-03-17T22:44:00.643

0

You have to use

context.getText(R.string.mycar);

just.
The context is the activity that is passed to the adapter.
It works for me.

edited Mar 17 '23 at 22:44

answered Mar 17 '23 at 22:42

Rasheed Al-Wahbany

1
2

Android setText / R.string / values

8 Answers8