TBXML parsing issue while the value cannot get in UILabel

Question

In my app i'm using TBXML parser where i need to get a value from xml file and print it on the label...This is my xml file in server

 <gold>
 <price>
 <title>22 K Gold</title>
 </price>
 <price>
 <title>24 K Gold</title>
 </price>
 </gold>

any my Viewcontroller.h looks like

#import <UIKit/UIKit.h>
#import "TBXML.h"

 @interface ViewController : UIViewController{

IBOutlet UILabel *lab;
TBXML *tbxml;
}



@end

and my Viewcontrooler.m looks like

 - (void)viewDidLoad
{
[super viewDidLoad];
// Do any additional setup after loading the view, typically from a nib.
NSData *xmlData = [[NSData alloc]initWithContentsOfURL:[NSURL URLWithString:@"http://www.abcde.com/sample.xml"]];
 tbxml = [[TBXML alloc]initWithXMLData:xmlData];


TBXMLElement * root = tbxml.rootXMLElement;

if (root)
{
    TBXMLElement * elem_PLANT = [TBXML childElementNamed:@"price" parentElement:root];
    while (elem_PLANT !=nil)
    {
        TBXMLElement * elem_BOTANICAL = [TBXML childElementNamed:@"title" parentElement:elem_PLANT];
        NSString *botanicalName = [TBXML textForElement:elem_BOTANICAL];
        lab.text=[NSString stringWithFormat:@"re %@", botanicalName];

        elem_PLANT = [TBXML nextSiblingNamed:@"price" searchFromElement:elem_PLANT]; 

        elem_BOTANICAL = [TBXML childElementNamed:@"title" parentElement:elem_PLANT]; 

        botanicalName = [TBXML textForElement:elem_BOTANICAL];
        lab1.text=[NSString stringWithFormat:@"re %@", botanicalName];
    }
}

}

i'm getting BAD_ACCESS thread.Am i missing anything...Help pls...

Rui Peres · Accepted Answer · 2012-07-05T07:57:44.653

1

lab.text=[NSString stringWithFormat:@"re %@",elem_BOTANICAL];

Edit 1.0:

lab.text=[NSString stringWithFormat:@"re %@", botanicalName];

Edit 2.0:

lab.text=[NSString stringWithFormat:@"re %@", botanicalName];

NSString *plantName = [TBXML textForElement: elem_PLANT];

lab1.text=[NSString stringWithFormat:@"re %@", plantName];

edited Jul 05 '12 at 07:57

answered Jul 05 '12 at 07:41

Rui Peres

25,741
9
87
137

If in case i'm creating two label and the two title in my xml file have to displayed in that how can i edit my code?...I tried but first title value is displayed in both label... – Vishnu Jul 05 '12 at 07:54
let us [continue this discussion in chat](http://chat.stackoverflow.com/rooms/13459/discussion-between-dany-and-jacky-boy) – Vishnu Jul 05 '12 at 12:44

score 1 · Answer 2 · answered Jul 05 '12 at 12:13

First of all I recommend you to parse your XML file in a separate method, so that your View will not mess with your Model. Create an object model for your XML item. Then, for instance, in one method you fill an array with objects that represent your items in XML file. And only then, when you retrieve those objects by parsing XML, you should bind this array with your view.

The second thing is you should put this line

elem_PLANT = [TBXML nextSiblingNamed:@"price" searchFromElement:elem_PLANT];

at the end of while cycle, because in the first iteration you work with the first item only, that was retrieved before while cycle began. So, if you put it in the middle, as you did, at some moment, at the end of parsing XML, the next lines after this line will work with a nil object.

The third thing is that before taking text from TBXMLElement, you should check if it is not nil:

NSString *plantName;
if (elem_PLANT) {
 plantName = [TBXML textForElement: elem_PLANT]; 
}

Can u tell me where i have to insert that NSString in my code...Because now i'm getting the value in lab but in lab1 "re" is displayed — Vishnu, Jul 05 '12 at 12:42
You insert this just in place of the line, that is in if statement. You should declare plantName before if statement, because compile will tell you that in some cases plantName is not declared (in cases when if statement is not true) — Denis Kutlubaev, Jul 09 '12 at 07:25

TBXML parsing issue while the value cannot get in UILabel

2 Answers2