setImageResource in GridView makes holes

Question

Hello everyone I have a problem. I want to do a GridView with a Custom Loyout so i used the layoutInflater and i did this:

private ImageView prima;
private ImageView seconda;

public View getView(int position, View convertView, ViewGroup parent) {
        View v;
        if (convertView == null) {

            LayoutInflater li = getLayoutInflater();
            v = li.inflate(R.layout.icon, null);

            Display display = getWindowManager().getDefaultDisplay();
            int width = display.getWidth();

            prima = (ImageView) v.findViewById(R.id.imageView1);
            prima.getLayoutParams().height = width / 3;
            prima.getLayoutParams().width = width / 3;
            seconda = (ImageView) v.findViewById(R.id.imageView2);
            seconda.getLayoutParams().height = width / 3;
            seconda.getLayoutParams().width = width / 3;

            v.setLayoutParams(new GridView.LayoutParams(width / 3, width / 3));
            v.setPadding(0, 0, 0, 0);
        } else {
            v = convertView;
        }

        prima.setImageResource(mThumbIds[position]); //mThumbIds[] is an array with R.drawable.vip_0_mini, R.drawable.a_1, R.drawable.b_2, R.drawable.c_3 .....
        return v;

    };

When i run my application the image are arranged random and there are many black space with no images.

What i did wrong ?

score 2 · Accepted Answer · answered Jun 28 '12 at 11:32

Your View and convertView are not linked. Try with ViewHolder concept like this:

public View getView(int position, View convertView, ViewGroup parent) {
        ViewHolder v;
        if (convertView == null) {

            LayoutInflater li = getLayoutInflater();
            convertView  = li.inflate(R.layout.icon, null);

            Display display = getWindowManager().getDefaultDisplay();
            int width = display.getWidth();

            v = new ViewHolder();
            v.prima = (ImageView) convertView .findViewById(R.id.imageView1);
            v.prima.getLayoutParams().height = width / 3;
            v.prima.getLayoutParams().width = width / 3;
            v.seconda = (ImageView) convertView .findViewById(R.id.imageView2);
            v.seconda.getLayoutParams().height = width / 3;
            v.seconda.getLayoutParams().width = width / 3;

            convertView .setLayoutParams(new GridView.LayoutParams(width / 3, width / 3));
            convertView .setPadding(0, 0, 0, 0);
            convertView.setTag(v);
        } else {
            v = (ViewHolder)convertView.getTag();
        }

        v.prima.setImageResource(mThumbIds[position]); //mThumbIds[] is an array with R.drawable.vip_0_mini, R.drawable.a_1, R.drawable.b_2, R.drawable.c_3 .....

         //v.seconda
        return convertView;

    };

class ViewHolder{
    ImageView prima;
    ImageView seconda;
}

I follow your example but when i run the gridview still have black images — Matteo Cardellini, Jun 28 '12 at 11:39
you are setting the params in the code even if you have inflated the layout. Please check this and make you are getting the images, else is looking fine. — Vineet Shukla, Jun 28 '12 at 12:09
Thank you i fixed ! I didn't write v.prima.setImageResource(mThumbIds[position]); — Matteo Cardellini, Jun 28 '12 at 12:52

score 0 · Answer 2 · answered Jun 28 '12 at 11:25

0

You forgot to apply images to

    seconda = (ImageView) v.findViewById(R.id.imageView2);

    prima.setImageResource(....);

answered Jun 28 '12 at 11:25

Vipul

27,808
7
60
75

No seconda and prima is a field. I didn't write in my post private ImageView prima; private ImageView seconda; – Matteo Cardellini Jun 28 '12 at 11:29

setImageResource in GridView makes holes

2 Answers2