TreeSet example

Question

Why the 3rd object is not being added to the treeset here though it is a different one?

import java.util.*;

class Student implements Comparable<Student>{
public String fn,ln;
public Student(String fn,String ln){
    this.fn=fn;
    this.ln=ln;
}

//overiding equals

public boolean equals(Object o) {
    if (!(o instanceof Student))
        return false;
    Student s=(Student) o;
    if(this==s)
        return true;
    if(this.fn.equals(s.fn) && this.ln.equals(s.ln))
        return true;
    return false;
}

//overiding hashcode

public int hashCode() {
    return fn.hashCode()+ln.hashCode();
}


//overiding compareTo

public int compareTo(Student o) {

    return this.fn.compareTo(o.fn);
}
  }

public class Practice {


public static void main(String[] args) {
    Student st1=new Student("Girish","J");
    Student st2=new Student("Master","M");
    Student st3=new Student("Girish","Jay");
    Set S=new TreeSet();

           //adding 3 different student objects

    System.out.println(S.add(st1));
    System.out.println(S.add(st2));
    System.out.println(S.add(st3));
    Iterator sitr=S.iterator();
    while(sitr.hasNext())
    {
        Student stu=(Student) sitr.next();
        System.out.println(stu.fn+" "+stu.ln);
    }


}

 }

Output:

true
true
false
Girish J
Master M

`Set S=new TreeSet();` should probably be `SortedSet S=new TreeSet();`. — S.L. Barth is on codidact.com, Jun 18 '12 at 11:55

score 11 · Accepted Answer · answered Jun 18 '12 at 11:55

11

Your comparator function only uses fn:

public int compareTo(Student o) {
    return this.fn.compareTo(o.fn);
}

TreeSet only uses ordering comparisons - it doesn't use hashCode() and equals().

By this comparison, st1 and st3 are equal (s1.compareTo(s3) will return 0) therefore st3 isn't added to the set.

If you want to maintain the distinction, you should probably compare fn and then use ln if the fn values are the same:

public int compareTo(Student o) {
    int fnResult = this.fn.compareTo(o.fn);
    return fnResult == 0 ? ln.compareTo(o.ln) : fnResult;
}

answered Jun 18 '12 at 11:55

Jon Skeet

1,421,763
867
9,128
9,194

Thanks Jon. while debugging I observed that Treeset doesn't use hashcode() and equals() for comparing. Interesting! So there's no way where you want to compare only first name? – Girish Jun 18 '12 at 11:59
+1 @Girish, You should have unique identifier for `Student` because it may happen where two students can have same first and last name – jmj Jun 18 '12 at 12:03
Well you *are* only comparing first name. That's exactly what it's doing, which is why it's rejecting the third student. It's not clear what you want the requirements to be. – Jon Skeet Jun 18 '12 at 12:03
@Jon: I was just learning the Collections by practising. No specific requirements as such. – Girish Jun 18 '12 at 12:48

score 2 · Answer 2 · answered Jun 18 '12 at 12:05

Your observations are correct that TreeSet does not use .equals and .hashcode for comparison.

From the javadocs:

This is so because the Set interface is defined in terms of the equals operation, but a 
TreeSet instance performs all element comparisons using its compareTo (or compare) method,
so two elements that are deemed equal by this method are, from the standpoint of the set, 
equal.

Basically, they are saying that for TreeSet, equality is determined not through .equals, but through .compareTo on the Comparable interface. Note that .compareTo should always be in line with .equals, meaning that if a.equals(b), then a.compareTo(b) == 0.

This has to do with the fact that TreeSet is an implementation of SortedSet. As such, it needs .compareTo in order to determine order, since .equals is not enough in that case.

PS: If you do not want to implement Comparable (which sometimes you can't since you might not always control the code of the objets), you could always pass a Comparator to the TreeSet constructor.

score 0 · Answer 3 · answered Jun 18 '12 at 11:57

Your comparison is only using the fn value...

public int compareTo(Student o) {
    return this.fn.compareTo(o.fn);
}

Which fails for the 3rd Student because the first name is identical to the 1st Student

You need to adjust your code to compare both the fn and the ln values...

public int compareTo(Student o) {
    int firstNameComparison = this.fn.compareTo(o.fn);
    if (firstnameComparison != 0){
        // the first names are different
        return firstNameComparison;
    }
    else {
        // the first names are the same, so compare the last name
        return this.ln.compareTo(o.ln);
    }
}

This code compares the fn values first. If they are identical, it then compares the ln values.

TreeSet example

3 Answers3

Linked