Proper way to work with FIFO buffer

Question

I have this FIFO which I'm going to use to store data from network server:

 Buffer nServerFifo = (Buffer) BufferUtils.synchronizedBuffer(new CircularFifoBuffer(200));

    // Insert into to the Network Server Buffer    
    public void nServerFifoAdd(String string){
        nServerFifo.add(string);        
    }

    // Get data from the Network Server Buffer
    public Object nServerFifoGet(){         
        Object string = nServerFifo.get();    
        nServerFifo.remove(string);
        return string;           
    }

My question is what is the proper way to store data insert and get data from the buffer? Do I need to delete the data after I get if or this is done by the buffer? Do you have Idea what is the maximum String length size that I can store into the buffer?

score 3 · Accepted Answer · edited Jun 17 '12 at 17:54

3

Its Better use ArrayBlockingQueue class which is present in java.util.concurrent package, which is Thread Safe.

BlockingQueue<String> queue = new ArrayBlockingQueue<String>(100);

queue.put("Vivek");   // To insert value into Queue

queue.take();         // To take the value out of Queue

edited Jun 17 '12 at 17:54

Edwin Dalorzo

76,803
25
144
205

answered Jun 17 '12 at 17:53

Kumar Vivek Mitra

33,294
6
48
75

What is the difference between ArrayBlockingQueue and CircularFIFOBuffer? Which one is faster? – user1285928 Jun 17 '12 at 18:01
ArrayBlockingQueue came into existence from java 1.5, and can do what all CircularFIFOBuffer did.. – Kumar Vivek Mitra Jun 17 '12 at 18:10
When I get string with `queue.take();` do I need to delete the queue element with with `queue.remove("Vivek");` or this is done automatically? – user1285928 Jun 17 '12 at 18:29
No, taking the next element from a queue removes and returns it. – David Harkness Jun 17 '12 at 19:33

score 1 · Answer 2 · answered Jun 17 '12 at 18:02

Assuming you're using the classes from Commons Collections:

If you use the remove() method, you do not need to additionally delete anything
The buffer stores object references, not strings, so it is limited by the number of slots allocated. In your case you could add up to 200 strings, of arbitrary length, limited by the total memory available to your program, before the buffer is full.

As Kumar pointed out, you're probably better off using the Java runtime library queueing classes instead, as they handle synchronization for you while the Commons Collections classes require you to lock on the iterator yourself.

In my case I store XML. Which buffer will you recommend for this purpose? — user1285928, Jun 17 '12 at 18:07

Proper way to work with FIFO buffer

2 Answers2