6

I want to take the next day by giving the current date The code i used as follows

+(NSDate *)getForDays:(int)days fromDate:(NSDate *) date {
    NSTimeInterval secondsPerDay = 24 * 60 * 60 * days;
        return [date addTimeInterval:secondsPerDay];
} 

this works fine but when the daylight saving enabled this leads to errors. How can I make this work when daylight saving is enabled.

TJ Seabrooks
  • 20,203
  • 6
  • 33
  • 30
Hasitha
  • 61
  • 1
  • 3
  • Can you specify the language you are using. It will help people when answering. – ChrisF Jul 07 '09 at 08:54
  • You should look into either renaming `seconds per day` or turning it into a constant and dropping the `* days` part. It's good practice in any language. – Rich Catalano Jul 07 '09 at 14:13

3 Answers3

13

As you have found, what you have now is pretty error-prone. Not only can it trip up over a daylight savings change, but also what if your user has a non-gregorian calendar? Then, days are not 24 hours long.

Instead, use NSCalendar and NSDateComponents which were exactly designed for this:

+ (NSDate *)getForDays:(int)days fromDate:(NSDate *)date
{
    NSDateComponents *components= [[NSDateComponents alloc] init];
    [components setDay:days];

    NSCalendar *calendar = [NSCalendar currentCalendar];
    return [calendar dateByAddingComponents:components toDate:date options:0];
}
Mike Abdullah
  • 14,933
  • 2
  • 50
  • 75
1

Use NSCalendar to perform calculations like this. Not only is it more likely to work, but your code will be clearer.

Peter Hosey
  • 95,783
  • 15
  • 211
  • 370
-1

I've no idea what language or system you're using here, but my advice would be to perform all of your calculations using time as UTC and only use local time when you come to display it.

Most operating systems and languages will factor in timzone and daylight saving on the conversion of UTC to local time.

ChrisBD
  • 9,104
  • 3
  • 22
  • 35