How to create a file and its parent directories in one method call?

Question

I want to create a file that is in specific directory. For example: C:\x\y\z\aTextFile.txt

For this operation, I have to create the directory to create file.

Directory.CreateDirectory(@"C:\x\y\z\");
File.Create(@"C:\x\y\z\aTextFile.txt");

But I really wonder that I can do this operation in single line of code.

Any help and idea will be greately appreciated.

Why is it so important to reduce this to one using a .Net framework specific method? — Chris Moutray, Jun 06 '12 at 05:55

score 4 · Answer 1 · edited Jun 18 '21 at 09:35

4

Simple: Add a function

void MySingleLineOfCodeFunction(string path, string filename)
{
    Directory.Createdirectory(path);
    File.Create(filename).Dispose();
}

and then use a single line of code:

MySingleLineOfCodeFunction(@"C:\x\y\z\", "a.txt");

What I am trying to say is that there is no difference between code. Some of it is written by the Microsoft guys, while other by us, normal people. But the computers don't make a difference. :)

edited Jun 18 '21 at 09:35

malat

12,152
13
89
158

answered Jun 06 '12 at 05:50

Petar Ivanov

91,536
11
82
95

I have a method like this but I want to reduce this two line of code to single line if it is possible – ibrahimyilmaz Jun 06 '12 at 05:53
2

You did reduce it to a single line, by combining it in to a method. There is no difference between your method calling those two API calls and some Microsoft function that calls the two API calls. You still MUST do two calls, one for the directory, one for the file. – Scott Chamberlain Jun 06 '12 at 05:55
I think there is a way to do this with built-in c# but there is no way np :) – ibrahimyilmaz Jun 06 '12 at 05:56
Sorry I was responding to ibrah, not you. I was trying to defend your point. – Scott Chamberlain Jun 06 '12 at 05:57
I know method extraction but I just wonder is there a built-in way. – ibrahimyilmaz Jun 06 '12 at 05:57
So we can say there is no way to do this except than method extraction :) sorry guys – ibrahimyilmaz Jun 06 '12 at 06:01
Please fix the sample code provided to use the parameters instead of the hard coded string. – Larry Jun 06 '12 at 06:03

Nikhil Agrawal · Answer 2 · 2012-06-06T06:03:49.047

2

Unfortunately no there is no single line of code to do what you want.

Why? Because even if we do so by some Microsoft inbuilt function, internally it will be calling two methods. One for Directory creation and other for file creation.

However you can reduce your lines of code by making them into a method and call it in a single line as Petar Ivanov said

OR

You can create a static extension method. This way you can use it at other places without creating instance. (Reduced your one line where instance is created).

edited Jun 06 '12 at 06:03

answered Jun 06 '12 at 05:54

Nikhil Agrawal

47,018
22
121
208

Since File is a static type you won't be able to create extension methods for File. – Prashanth Thurairatnam Jun 06 '12 at 06:37

Larry · Accepted Answer · 2012-06-06T06:08:35.090

2

As far I know, there is no File creation method that create the directory at the same time in the .NET framework.

If the pattern "Directory check/creation, then file creation" is repeated a lot in your code, you have to implement it in a method.

edited Jun 06 '12 at 06:08

answered Jun 06 '12 at 06:01

Larry

17,605
9
77
106

score 2 · Answer 4 · edited Jun 18 '21 at 09:34

I've modified the answer from @Petar_Ivanov, to work out the parent directory based on the file path, thought it may be useful to others who might want a similar function.

    public void CreateFile(string filePath)
    {
        if (!File.Exists(filePath))
        {
            var parent = Directory.GetParent(filePath);
            Directory.CreateDirectory(parent.FullName);
            File.Create(filePath).Dispose();
        }
    }

score 1 · Answer 5 · answered Jun 06 '12 at 06:24

For creating a file, no, the directory has to exist. Even with Visual Basic's file friendly classes, you still have to create the directories first. What is interesting is that moving will create the folder.

From CreateFile http://msdn.microsoft.com/en-us/library/windows/desktop/aa363858(v=vs.85).aspx

Directories

An application cannot create a directory by using CreateFile, therefore only the OPEN_EXISTING value is valid for dwCreationDisposition for this use case. To create a directory, the application must call CreateDirectory or CreateDirectoryEx

+1. You beat me to it :) This is not a limitation of the .NET framework, but it is a limitation the Win32 API. — Eren Ersönmez, Jun 06 '12 at 06:30

score 0 · Answer 6 · answered Oct 01 '15 at 12:35

0

Mostly in my code blocks; I handle folder existence right before file create parts.

public void CheckCreatePath(fileName)
{
    string filePath = Directory.GetParent(fileName).ToString();
    if (!Directory.Exists(filePath))
        Directory.CreateDirectory(filePath);
}

and just use

CheckCreatePath("C:\\TEMP\\TESTPath\\myFile.txt");

in your code block.

answered Oct 01 '15 at 12:35

NejatDevrim

1

Does this work if `\TEMP` does not exit? The question says "parent directories". – Old Geezer Mar 05 '20 at 08:22

How to create a file and its parent directories in one method call?

6 Answers6