SqlDataReader and concurrency/deallocation issues

Question

Running the below code is giving me an error:

.NET Framework execution was aborted by escalation policy because of out of memory. System.InvalidOperationException: There is already an open DataReader associated with this Command which must be closed first.

I have the following code all over the place to run my sql:

sql.Append(string.Format("SELECT TableId FROM ps_SavedTables WHERE guid = '{0}'", guid));

    using (IDataReader reader = SqlHelper.GetDataReader(sql.ToString())) {
        if (reader.Read()) {
            result = reader.IsDBNull(0) ? string.Empty : reader[0].ToString();
        }
        //CDW added to close SqlDataReader
        reader.Close();
    }

The GetDataReader is defined by this:

public static SqlDataReader GetDataReader(string sql, string connectionString) {
    lock (_lock) {
        SqlConnection connection = null;
        try {
            connection = GetConnection(connectionString);
            //connection.Open();
            using (SqlCommand cmd = new SqlCommand(sql, connection)) {
                WriteDebugInfo("GetDataReader", sql);
                return cmd.ExecuteReader(CommandBehavior.CloseConnection);
            }
        }
        catch (Exception e) {
            if (connection != null)
                connection.Dispose();
            throw new DataException(sql, connectionString, e);
        }

    }
}

Can you give us a bit more detail about the exception? Where it's thrown? Stack trace etc? — Dave Lawrence, May 23 '12 at 08:23
possible duplicate of [Deallocation of SqlDataReader](http://stackoverflow.com/questions/10712860/deallocation-of-sqldatareader) — Jesse C. Slicer, May 23 '12 at 19:24

score 1 · Answer 1 · answered May 23 '12 at 08:29

1

The lock needs to be at the reader level... Multiple threads are opening readers

answered May 23 '12 at 08:29

Dave Lawrence

3,843
2
21
35

@Totero I'm glad someone had the manners to comment. Thanks. Poor stuff from the op. Spam merchant. – Dave Lawrence May 31 '12 at 09:43
Oh you like what he's selling! It brings the boys to the yard apparently – Dave Lawrence May 31 '12 at 09:44

SqlDataReader and concurrency/deallocation issues

1 Answers1

Linked