Changing a label's text in another form in C#?

Question

I have a label called LabelX1. This is on form2. On form1, i have a button. I want the button's text to be transferred to the other form's label. I have tried

form2 frm2 = new form2();
frm2.labelX1.Text = this.button1.text;

But it does not work. Is there an easy, straight forward way of doing this?

Do you have the instance of form2 already displayed? In that way you create another instance of form2 and set the label text there. And that instance is neved displayed (eg. Show() / ShowDialog()) — Steve, May 22 '12 at 14:27

score 33 · Accepted Answer · answered May 22 '12 at 14:26

You need to expose your label or its property.

In form 2:

public string LabelText
{
    get
    {
        return this.labelX1.Text;
    }
    set
    {
        this.labelX1.Text = value;
    }
}

Then you can do:

form2 frm2 = new form2();
frm2.LabelText = this.button1.text;

score 9 · Answer 2 · answered May 22 '12 at 14:31

9

You could modify the constructor of Form2 like this:

public Form2(string labelText)
{
    InitializeComponent();
    this.labelX1.Text = labelText;
}

then create Form2 passing in the text:

Form2 frm2 = new Form2(this.button1.text);

answered May 22 '12 at 14:31

Eric Dahlvang

8,252
4
29
50

I agree this will work, but it would be a one time change. And maybe that is good enough for the OP. – General Grey May 22 '12 at 14:35
@K'Leg well, they didn't indicate whether or not they need to change it again...I'm just providing options. – Eric Dahlvang May 22 '12 at 14:37
I agree if this is all he wants then I think this is the best answer. It is easier then creating a property for the text label. – General Grey May 22 '12 at 14:39

score 6 · Answer 3 · answered May 22 '12 at 14:36

6

Or you can do this >>

((Label)frm2.Controls["labelX1"]).Text = "test";

answered May 22 '12 at 14:36

banging

2,540
1
22
26

score 5 · Answer 4 · answered May 22 '12 at 14:35

5

inside form2 write this

public void ChangeLabel(string s)
{
    labelX1.Text = s;
}

then where you create Form 2 do this

form2 frm2 = new form2();
frm2.ChangeLabel(this.button1.text);

answered May 22 '12 at 14:35

General Grey

3,598
2
25
32

hawk · Answer 5 · 2012-05-22T14:31:27.580

3

Is there an easy, straight forward way of doing this?

Easiest way is to make labelX1 a public member of form2. The issue you're having is because from Form1 code form2.labelX1 isn't visible. In form2 designer you can go to properties of labelX1 and set it's visibility to public/internal.

Better approach would be to expose labelX1.Text as a property which can be set in code outside the class.

edited May 22 '12 at 14:31

answered May 22 '12 at 14:25

hawk

1,827
2
14
28

1

your answer is still not correct Visibility to protected will not help anything – Micah Armantrout May 22 '12 at 14:27
yea i accidentally wrote protected, i really meant public... i was editing while you commented! – hawk May 22 '12 at 14:28

score 1 · Answer 6 · edited Feb 20 '19 at 00:42

1

You can make labelX1 public, and it will work, but there is a better way to do this:

http://www.codeproject.com/Articles/14122/Passing-Data-Between-Forms

edited Feb 20 '19 at 00:42

marsnebulasoup

2,530
2
16
37

answered May 22 '12 at 14:29

Micah Armantrout

6,781
4
40
66

score 1 · Answer 7 · answered Nov 10 '15 at 20:54

1

form2 frm2 = new form2();
((Label)frm2.Controls["labelX1"]).Text=button1.Text;
frm2.Show();

answered Nov 10 '15 at 20:54

Hstm91

11
2

score 1 · Answer 8 · answered Oct 31 '18 at 21:52

1

the only think you have to do is to put the label of the other form as public

for instance: Form1:

 public System.Windows.Forms.Label txtInfo;

then in Form2

Form1 frm =new Form1();
frm.txtInfo.text="....."//you have access because is public

answered Oct 31 '18 at 21:52

john pispidikis

11
1

score 0 · Answer 9 · edited Oct 21 '15 at 14:18

0

I changed my parent window property to the following code:

this.MdiParent.Controls["label1"].Text = "test";

edited Oct 21 '15 at 14:18

maxshuty

9,708
13
64
77

answered Oct 21 '15 at 13:28

Amit Gohel

11

score 0 · Answer 10 · answered Nov 01 '17 at 17:10

If you are needing to access the form2 from elsewhere in your code (like a button press for instance) you will not be able to see the instance of the form you create. To solve that I create a public instance to hold a reference to it like:

 public form2 form2_pub;

Then after you create it you assign the new one to your public instance:

form2 frm2 = new form2();
frm2.Show();
form2_pub = frm2

Now you can reference form2_pub throughout your routines.

Works for me at least.

Remember, in your setter you can run whatever other code you want. For instance, I use the following to show what I want on another form by just setting show_scanning to true:

  public bool show_scanning //turns on the scanning screen
    {
        set
        {
            scanning_pnl.Visible = true;
            notReady_pnl.Visible = false;
            timer1.Enabled = true;
        }
    }

score 0 · Answer 11 · answered Nov 21 '18 at 04:18

Generally the controllers are private. That is why you unable to access it from another form. Above mentioned ways such as passing data through parameters etc are so correct. There is one another method, Go to your form Form2.Designer.cs

private System.Windows.Forms.Label labelX1;

Change 'private' into 'public'. Now the labelX1 is visible to outside.

score 0 · Answer 12 · edited Jun 17 '21 at 10:34

0

The another approach is Just change the modifier property of label or text to public and now it allows to access the content of form1 textbox to label on another form

So the code is

private void button1_click(){
    Form2 obj1 =new Form2();
    Obj1.show();
    Obj1.label1.text="welcome"+textbox1.Text;
}

edited Jun 17 '21 at 10:34

Grigory Zhadko

1,484
1
19
33

answered Jun 17 '21 at 05:41

kalyani satone

9
2

score -1 · Answer 13 · answered May 22 '12 at 14:26

-1

Do you have exception? You can make public property on form2, with setter to set text on the label, or make labex1 access modifier public and set it directly. It should work.

answered May 22 '12 at 14:26

Val Bakhtin

1,434
9
11

@Killercam error is clear for who? He did not post any error information. – Val Bakhtin May 22 '12 at 14:30
If you do not have enough information to answer comment instead - asking for the details. What you have supplied it not an answer. – MoonKnight May 22 '12 at 14:37
For some it is. You set access modifier from a prop box, not a code. But nvm. – Val Bakhtin May 22 '12 at 14:39

Changing a label's text in another form in C#?

13 Answers13

Linked