0

I'm trying to write bytes to a file with a BufferedOutputStream but I need this to work in a while loop. This is mean to work with a TFTP server. It writes the file with absolutely nothing in it (which is pointless). Can anyone help me with this?

            WRQ WRQ = new WRQ();
            ACK ACK = new ACK();
            DatagramPacket outPacket;
            BufferedOutputStream bufferedOutput = new BufferedOutputStream(new FileOutputStream(filename));
            byte[] bytes;
            byte[] fileOut;
            outPacket = WRQ.firstPacket(packet);
            socket.send(outPacket);

            socket.receive(packet);

            while (packet.getLength() == 516){

            bytes = WRQ.doWRQ(packet);
            bufferedOutput.write(bytes);

            outPacket = ACK.doACK(packet);
            socket.send(outPacket);

            socket.receive(packet); 

            }

            bytes = WRQ.doWRQ(packet);
            bufferedOutput.write(bytes);

            outPacket = ACK.doACK(packet);
            socket.send(outPacket);
DMo
  • 591
  • 2
  • 6
  • 13

4 Answers4

3

You're not closing the stream when you're done with it.

Louis Wasserman
  • 191,574
  • 25
  • 345
  • 413
1

Are you missing bufferedOutput.flush() to flush out all the buffered data.

Danish Shrestha
  • 487
  • 5
  • 16
0

Just try and close your BufferedOutputStream.

Add bufferedOutput.close();

If you don't close your OutputStream, you could lose buffered data, that is what is happening in your case maybe. Either close it, or flush it.

Kazekage Gaara
  • 14,972
  • 14
  • 61
  • 108
0

You will need to use the BufferedOutputStream's flush() method so that all results would be written out. Invoking the close() method also performs a flush().

http://www.javapractices.com/topic/TopicAction.do?Id=8

Simon
  • 31,675
  • 9
  • 80
  • 92
user1348384
  • 83
  • 1
  • 5