iOS Implicit conversion of int to NSNumber is disallowed with ARC

Question

on following code i'm get the errormessage: Implicit conversion of 'int' to 'NSNumber *' is disallowed with ARC.

What i'm making wrong?

<pre>
 <code>
  NSDictionary *results = [jsonstring JSONValue];
  NSNumber *success = [results objectForKey:@"success"]; // possible values for "success": 0 or 1

   if (success == 1) { // ERROR implicit conversion of int to NSNumber disallowed with ARC    
   }
 </code>
</pre>

Thanks for any help or hint!

regards, Daniel

rishi · Answer 1 · 2012-05-18T11:22:29.260

28

Erro because you are comparing NSNumber with int.

Try like -

if ([success isEqual:[NSNumber numberWithInt:1]])

or

if ([success intValue] == 1)

edited May 18 '12 at 11:22

answered May 18 '12 at 10:57

rishi

11,779
4
40
59

1

The first comparison is wrong, you're comparing pointer values of distinct objects. You'd want `[success isEqual:[NSNumber numberWithInt:1]]` or better yet, the second comparison. – DarkDust May 18 '12 at 11:06

score 15 · Accepted Answer · answered May 18 '12 at 10:57

15

You should use [success intValue] == 1. An NSNumber is a class, so number is a pointer, not the direct value.

answered May 18 '12 at 10:57

score 3 · Answer 3 · answered May 18 '12 at 10:58

3

NSNumber is an object (i.e. a pointer), so you can't just compare it to a integer literal like 1. Instead you have to extract the int value from the number object:

if ([success intValue] == 1) {
   ...
}

answered May 18 '12 at 10:58

omz

53,243
5
129
141

score 1 · Answer 4 · answered May 18 '12 at 11:00

1

If success should indicate a boolean, you may want to try this

NSDictionary *results = [jsonstring JSONValue];
NSNumber *success = [results objectForKey:@"success"]; 

if ([success boolValue]) { 
  // success!
}

answered May 18 '12 at 11:00

tilo

14,009
6
68
85

iOS Implicit conversion of int to NSNumber is disallowed with ARC

4 Answers4