FMDB sqlite insert failed

Question

Coming from a non-SQL background, i create a simple table, named test, with 3 fields:

    NSString *testtable = @"create table if not exists test(testid integer primary key, userid integer, contentid text)";
if (![db executeUpdate:testtable]) {
    NSLog(@"create test, %d:%@", [db lastErrorCode], [db lastErrorMessage]);
    return NO;
}

when i insert a record to the table ,i got an exc_bad_access error:

    if (![db executeUpdate:@"insert into test values(?,?,?)", NULL, 1, @"HELLO"]) {
    NSLog(@"insert test, %d:%@", [db lastErrorCode], [db lastErrorMessage]);
    return NO;
}

If i change column 'userid' type from integer to text ,this will work well. And i test the table using sqlite command on the console, it works well too. What do you guys think? Thanks...

i try another way to handle this problem:

    if (![db executeUpdate:@"insert into test values(?,?,?)", NULL, [NSNumber numberWithInt:1], @"HELLO"]) {
    NSLog(@"testint, %d:%@", [db lastErrorCode], [db lastErrorMessage]);
    return NO;
}

then it works. I can not tell the reason... Maybe fmdb only supports object insert.

Just our NSLog with ErrorCodes helped me solve my problem... +1 — CampbellGolf, Jan 29 '14 at 09:37

score 2 · Accepted Answer · answered May 15 '12 at 14:39

2

I believe FMDB needs objects to replace the ? and int's are not objects. Change the 1 to [NSNumber numberWithInt:1]

Also, where you open your database you have something like this?

db = [FMDatabase databaseWithPath:writableDBPath];

    if ([db open]) {

Add [db setTraceExecution:TRUE]; immediately after and it'll nslog your SQL text for you.

It is possible to create your SQL NSString first, and insert your int, then get FMDB to just run your already populated string.

answered May 15 '12 at 14:39

Darren

10,182
20
95
162

yes, Darren, you're right. i read the fmdb doc carefully, find this: "All arguments provided to the -executeUpdate: method (or any of the variants that accept a va_list as a parameter) must be objects. The following will not work (and will result in a crash)" I try to use the executeUpdateWithFormat in my code, it works well. And i add the traceExecution by your suggestion. Now i can get more info from fmdb. Thanks! – user1396268 May 16 '12 at 02:33

score 0 · Answer 2 · answered May 15 '12 at 18:45

executeUpdate: Only supports objects passed as placeholder values. You can use executeQueryWithFormat: if you'd rather have printf style arguments (where you can use %d to represent your number). Personally I'd stick with the objects though, since executeQueryWithFormat: is going to end up converting the values into objects anyway.

FMDB sqlite insert failed

2 Answers2