Will JPA try to cascade persist and already persistent entity?

Question

Will JPA try to cascade persist on an entity that is already persistent (and non-detached)?

To make things clear, here's my situation: I want to persist a new User:

public void addUser(){
    //User is an entity that is related to many Groups
    //The relationship on User side is marked with cascade persist
    User user = new User();
    user.setName("foo");
    user.setGroups(new ArrayList<Groups>());

    //selectedGroups is an List of Groups previously created with persistent Groups
    for(Group g : this.selectedGroups){
        user.getGroups().add(this.groupDao.find(g.getId()));
    }
    //At this point, User.getGroups() is a list of Managed Entities

    //What happens on the following line?
    userDao.persist(user);
}

So, what happens? Will JPA try to persist (again) every single group in user.getGroups()? Or will it detect that those groups already exist and just update new relations?

In case of 'Yes, it will persist again', how should I annotate this relation to make that code work properly?

As far as i've tested, it tries to persist the entities again. But i don't know if i'm doing something wrong... — Pedro Peixoto, May 14 '12 at 12:12
The JPA 2 spec says, at section 3.2.2: "If X is a preexisting managed entity, it is ignored by the persist operation". So you're doing something wrong. — JB Nizet, May 14 '12 at 12:30

Eelke · Accepted Answer · 2012-05-14T19:55:09.093

3

JPA will detect the difference between new groups and already persisted groups and will only persist new groups.

edit: in response to comments

JPA probably tries to persist them again because they have been detached. This means you either have to attach them again using merge or prevent them from being detached.

The most likely reason for them becoming detached is the end of the transaction they were part of. Assuming you are using JTA and did nothing extra then if addUser is not a method of an EJB while groupDao is an EJB then the transaction starts with the groupDao.find call and ends the moment find returns. Because by default an EJB method starts a transaction if not one is already running. If addUser is a method of an EJB things should be fine because then addUser will start the transaction and groupDao.find will use the existing transaction so everything happens in one transaction.

edited May 14 '12 at 19:55

answered May 13 '12 at 08:09

Eelke

20,897
4
50
76

As far as i've tested, it tries to persist the entities again. But i don't know if i'm doing something wrong... – Pedro Peixoto May 14 '12 at 12:18
Expanded my answer to address the most likely cause of your problem. – Eelke May 14 '12 at 19:55
The problem is that i was using persistant entities, but outside a EntityManager transaction, and thus, as tou said, detached. Thanks for the info. – Pedro Peixoto May 15 '12 at 16:40

Will JPA try to cascade persist and already persistent entity?

1 Answers1