Bada, Static pointer crash

Question

I've got some problem with static pointers and variables in Bada. First I tried to create singleton class and did something like this: Header:

    static Session *getInstanceOf();
private:
    static Session *instance;

Source:

Session* Session::getInstanceOf(){
    if (instance==NULL){
        instance=new Session();}
    return instance;
}

But application crashed without any error message. Then I tried creating static class field and returning it by:

ArrayList* User::GetUniv()
{
    return &Universities;
}

But it had the same result. Do you have any idea why is it so? Thanks for any help.

Not enough information. Are you using multiple threads? Also, this code leaks. — Konrad Rudolph, Apr 25 '12 at 15:29
Regarding your singleton solution: Did you initialize your Session pointer to NULL? Also where did it crash? Within the getInstanceOf function, or when you use the returned ptr, etc. ? — lx., Apr 25 '12 at 15:30

Michael Wild · Answer 1 · 2012-04-25T15:44:15.037

1

Are you initialising Session::instance in your implementation file? Like this:

Session* Session::instance = NULL;

Edit: Also consider the static initialization order fiasco.

edited Apr 25 '12 at 15:44

answered Apr 25 '12 at 15:30

Michael Wild

Thanks it helped. Surprisingly in both cases. Cheers. – jimmy Apr 25 '12 at 17:02
Cool. In that case you can pick the post that (in your opinion) answered your problem best and accept it by clicking the tick-mark. – Michael Wild Apr 25 '12 at 17:22

score 1 · Answer 2 · answered Apr 25 '12 at 15:34

1

You can do like this

ArrayList* User::GetUniv()
{
    static Universities;
    return &Universities;
}

answered Apr 25 '12 at 15:34

Denis Ermolin

score 0 · Answer 3 · answered Apr 25 '12 at 15:32

0

This is somewhat dangerous:

if (instance==NULL){
    instance=new Session();}

Because your instance doesn't appear to have been initialized to NULL. Pointers may have a garbage value when uninitialized.

answered Apr 25 '12 at 15:32

Benj

3 Answers3