memory is growing in audio buffer code

Question

I have a code that we use many times with our apps, its a class that take the buffer samples and process it ,then send back notification to the main class. The code is c and objective-c.

It works just great, but there is a memory growing which i can see in instruments-allocations tool. the "overall bytes" is keep growing, in 100k a second. becuase of some parts of the code that i know who they are .

this is the callback function, with the line that makes problems. it happens many times a second. I also dont really understand where to put my *pool :

    static OSStatus recordingCallback(void *inRefCon, 
                                      AudioUnitRenderActionFlags *ioActionFlags, 
                                      const AudioTimeStamp *inTimeStamp, 
                                      UInt32 inBusNumber, 
                                      UInt32 inNumberFrames, 
                                      AudioBufferList *ioData)
    {

        AudioBuffer buffer;
        buffer.mNumberChannels = 1;
        buffer.mDataByteSize = inNumberFrames * 2;
        //NSLog(@"%ld",inNumberFrames);
        buffer.mData = malloc( inNumberFrames * 2 );
        // Put buffer in a AudioBufferList
        AudioBufferList bufferList;
        bufferList.mNumberBuffers = 1;
        bufferList.mBuffers[0] = buffer;


        // block A
        OSStatus status;
        status = AudioUnitRender(audioUnit, 
                                 ioActionFlags, 
                                 inTimeStamp, 
                                 inBusNumber, 
                                 inNumberFrames, 
                                 &bufferList); 

       //end block A

         NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init]; 
        int16_t *q = (int16_t *)(&bufferList)->mBuffers[0].mData;
        int16_t average ;

        for(int i=0; i < inNumberFrames; i++)
        {


            average=q[i];   

            if(average>100) // lineB 
                reducer++;

           //blockC
            if(reducer==150 )
            {

                average= preSignal + alpha*(average-preSignal);
                //NSLog(@"average:%d",average);

                //call scene
                [dict setObject:[NSNumber numberWithInt:average] forKey:@"amp" ] ;
                [[NSNotificationCenter defaultCenter] postNotificationName:@"DigitalArrived" object:nil userInfo:dict];
                reducer=0;
                preSignal=average;

            }
//end blockC

        }


         free(buffer.mData);
         [pool release];
        return noErr;


}

OK: ignore blockC for a second. removing blockA and lineB solve it all. removing only one of them- leaks.

i just cant undetstand what is growing here .

check the address of buffer.mData before you free() it. Is it the same as the address returned from malloc() ? — hooleyhoop, Apr 23 '12 at 13:03

score 0 · Accepted Answer · answered Apr 23 '12 at 11:24

0

Just a guess, but allocating a new NSAutoreleasePool inside of your recording callback function (which is a super time-critical function) is probably a bad idea.

Actually, why are you doing this here at all? Shouldn't you just have one pool for the entire app, in your main.m? This is probably causing some of your leaks.

answered Apr 23 '12 at 11:24

Nik Reiman

39,067
29
104
160

the reason is because if i dont put that thread here, there is no pool for the autorelease objects here . and i get the error: "autoreleased with no pool in place - just leaking " so i have add this after i read this: http://stackoverflow.com/questions/6377730/iphone-autoreleased-with-no-pool-in-place-just-leaking – user1280535 Apr 23 '12 at 12:56

score 0 · Answer 2 · answered Apr 23 '12 at 15:56

0

You should not do anything the requires memory allocation inside an Audio Unit render callback. The real-time requirements are too tight for using generic Objective C.

Since you should not allocate a pool, or any other memory, inside an audio unit callback, you should not use any Objective C methods that potentially or actually create any objects, such as dictionary modifications or notification creation. You may have to drop back to using plain C inside the render callback (set a flag), and do your Objective C messaging outside the render callback in another thread (after polling the flag(s) in a timer callback, for instance).

answered Apr 23 '12 at 15:56

hotpaw2

70,107
14
90
153

thanks a lot but the problem is that even if i erase all the inside of the callback and just put the code above, still i have leaks because of the blockA. why is that ??? – user1280535 Apr 23 '12 at 16:11
Did you remove the malloc()? (or move it outside the callback?) – hotpaw2 Apr 23 '12 at 16:34
no i didnt, should i? according to apple and many guides on the net, it should be there . i have malloc and free. – user1280535 Apr 23 '12 at 17:22
while this is true for performance reasons, it isn't going to cause a memory leak, so doesn't directly answer the Q. – hooleyhoop Apr 23 '12 at 18:28

memory is growing in audio buffer code

2 Answers2

Linked