how can i stop' Invalid argument supplied for foreach() 'from being reported on website front end

Question

PHP Warning: Invalid argument supplied for foreach() in /home/synergie/public_html/ss/libraries/joomla/database/database/mysql.php on line 377

It comes up intermittently but often in both front and back of my joomla website. I am not expert in this area but it appears to be out of scope for everyone I ask for help. Since I cannot stop the error from occurring I was hoping you could help me to disable or block it from reporting.

this is the code I am dealing with:

  // If we want the whole field data object add that to the list.
            //else
            {
                foreach ($fields as $field)
                {
                    $result[$field->Field] = $field;
                }
            }

            return $result;

@titus1972 It actually is wonderful advice. In designing PHP you should fix errors, not hide them. — Bailey Parker, Apr 21 '12 at 21:11
@PhpMyCoder That's what I said thanks for the wonderful advice the disabling the error thing, that is simply a temporary measure until I can actually address the root cause itself. But Thanks for your concern. — titus1972, Apr 21 '12 at 23:49
@titus1972 My apologizes. I thought I detected a hint of sarcasm in your comment. I guess I was wrong. — Bailey Parker, Apr 21 '12 at 23:50

score 4 · Answer 1 · answered Apr 21 '12 at 20:54

4

Are you sure that you're looping through an array and not an object? Just to be sure, consider changing to:

foreach((array)$fields as $field)
{
    $result[$field->Field] = $field;
}

answered Apr 21 '12 at 20:54

maiorano84

11,574
3
35
48

I had no idea typecasting would work, brilliant way to keep it on one line! – Nick Cardoso Aug 07 '14 at 19:49

score 2 · Answer 2 · answered Apr 21 '12 at 20:40

2

Maybe a try catch block?

try {
    foreach( $array as $v ) {
        // do dtuff
    }
} catch( Exception $e ) {
    echo 'Caught exception';
}

answered Apr 21 '12 at 20:40

gimg1

1,121
10
24

1

try / catch does not work for those kind of warnings unless you convert them into exceptions which is easily possible with [`ErrorException`](http://php.net/ErrorException). – hakre Apr 22 '12 at 09:19

score 2 · Answer 3 · answered Apr 21 '12 at 20:41

2

You can turn off error reporting with this function:

error_reporting(0);

answered Apr 21 '12 at 20:41

Hüseyin Z.

836
1
8
18

score 2 · Answer 4 · answered Apr 21 '12 at 20:44

If this is a production environment and you simply want to disable warning messages like this (I'm assuming that this is code that you didn't write since you mention Joomla), try disabling error reporting in your php.ini file.

Change:

display_errors On

to

display_errors Off

Note that if this is a development environment you should probably leave error reporting on and fix any warnings.

score 2 · Answer 5 · edited May 23 '17 at 11:58

2

Instead of hiding the error, you should be checking that you are passing something Traversable to foreach(). You can do that with @NullUserException's is_iterable():

function is_iterable($var) {
    return (is_array($var) || $var instanceof Traversable);
}

if(is_iterable($fields)) {
     foreach($fields as $field) {
         // Processing $field here
     }
} else {
    echo "Fields is not iterable";
}

edited May 23 '17 at 11:58

Community

1
1

answered Apr 21 '12 at 21:17

Bailey Parker

15,599
5
53
91

is_array() is probably the most simple way to check, but this is certainly more exhaustive – Ross Jan 18 '13 at 14:39

score 0 · Answer 6 · answered Feb 17 '15 at 12:17

I would definitely choose the syntax:

if(is_array($fields)){
    foreach($fields as $field){
        //do stuff
    }
}

Be careful by using the nice and attractive short form :

foreach((array)$fields as $field)

if $fields contains complex data structure (not a simple array) the casting may compromise your content.

how can i stop' Invalid argument supplied for foreach() 'from being reported on website front end

6 Answers6