Is using a predecrement operator on the right hand side of an assignment valid C++?

Question

I almost never put a ++ or -- anywhere except on its own line. I know they can lead to undefined behavior and can be hell for debugging. But for verbosity purposes, I'm tempted. Is this valid code?

map<int, int> dict;

...

int key = ...;
if (dict.lower_bound(key) != dict.begin()) {
  int prevval = (--dict.lower_bound(key))->second;
  ...
}

I'd like to just do

int prevval = (dict.lower_bound(key)-1)->second;

but bidirectional iterators don't have operator-() defined.

Thanks!

If you are unsure about that operation sequence - use more parentheses — Ulterior, Apr 13 '12 at 17:58

score 2 · Accepted Answer · answered Apr 13 '12 at 17:54

2

Yes, it's perfectly valid and works as expected.

Undefined behavior when using these operators usually come from modifying a variable multiple times between sequence points, which is not your case.

answered Apr 13 '12 at 17:54

Luchian Grigore

253,575
64
457
625

score 1 · Answer 2 · answered Apr 13 '12 at 18:09

Actually you are doing an initialization and not an assignment, but that doesn't change anything.

However, your code is valid, because there is no choice in the order of applying all the operators. You have to be careful if an expression can be split in subexpressions which could be evaluated in arbitrary order.

Is using a predecrement operator on the right hand side of an assignment valid C++?

2 Answers2