Validation Attribute get triggered two times

Question

In my MVC3 application I have the model ( not important properties deleted ):

public class AccountViewModel
{
    [StringLength(65)]
    public string Property1 { get; set; }

    [StringLength(65)]
    public string Property2 { get; set; }
}

The problem is when an action is submited validation attribute called twice, and I can get 4 errors in summary, instead of 2:

'Property1' length must be less than 65 characters
'Property1' length must be less than 65 characters
'Property2' length must be less than 65 characters
'Property2' length must be less than 65 characters

I dont use Validate method in my controller's code. The problem appears also with my custom attributes, but its not happens with Required attribute. Also I have to note that ctor of the custom attributes also called twice

My action

[HttpPost]
public ActionResult CreateOrEdit(AccountViewModel model) {

    if (!ModelState.IsValid) {
        return View("Edit", model);
    }

    try {
        _accountService.InsertOrUpdate(model);

    }
    catch (Exception ee) {
        ModelState.AddModelError("", ee.Message);
        return View("Edit", model);
    }

    return RedirectToAction("Index");
}

On View I render my errors using:

@{
    var errors = ViewData.ModelState.Errors();
    <div class="alert alert-block alert-error @(errors.Count == 0 ? "hide" : "")" > 
    <h4 class="alert-heading"> You got an error!</h4> 
    <ul>
        @foreach (var error in errors) {
            <li>@error</li>
        }
    </ul>
    </div>
}

And I double re-check once more that ViewData.ModelState already contains errors twice.

Hmmm you have 55 in attribute declaration and 65 value in error message — Michal Franc, Apr 12 '12 at 18:36
can you post the action? also, confirm that you are not calling `ValidationSummary` twice in your view. — Steve Mallory, Apr 12 '12 at 18:37
Yes, Im not using ValidationSummary method at all @Steve Mallory — frm, Apr 12 '12 at 18:41
@bogert then I don't understand where you are seeing the messages — Steve Mallory, Apr 12 '12 at 18:49
I updated post with view markup, note that ModelState already contains double error @Steve Mallory — frm, Apr 12 '12 at 19:02
Have you customized the `ModelValidatorProviders`? Maybe you have registered the `DataAnnotationsModelValidatorProvider` twice. — nemesv, Apr 12 '12 at 19:07
I have re-checked that, the only mention about that is "DataAnnotationsModelValidatorProvider.AddImplicitRequiredAttributeForValueTypes = false;" but with or without this line - no change @nemesv — frm, Apr 12 '12 at 19:12
Just re-checked, have no custom model binders @Steve Mallory — frm, Apr 12 '12 at 19:37

frm · Accepted Answer · 2012-04-13T08:27:33.453

3

The problem was in integrating Ninject. If you use Ninject.MVC package ( I use version 3 ) it registers his own ModelValidationProvider while initializing and removes the old one:

In Ninject.Web.Mvc.MvcModule

this.Kernel.Bind<ModelValidatorProvider>().To<NinjectDataAnnotationsModelValidatorProvider>();

In Ninject.Web.Mvc.NinjectMvcHttpApplicationPlugin:

public void Start()
{
    ModelValidatorProviders.Providers.Remove(ModelValidatorProviders.Providers.OfType<DataAnnotationsModelValidatorProvider>().Single());
    DependencyResolver.SetResolver(this.CreateDependencyResolver());
    RemoveDefaultAttributeFilterProvider();
}

So, rather than creating my own implementation of IDependencyResolver ( Ninject Kernel wrapper ) I followed this tutorial or you should remove Ninject.MVC package and remove its binaries from the bin folder.

edited Apr 13 '12 at 08:27

answered Apr 13 '12 at 07:59

frm

1,720
1
14
18

The Ninject extension does not cause that problem if used correctly. Althouth w/o knowing how you set up ninject it is impossible to give you an answer. – Remo Gloor Apr 13 '12 at 23:14
You right, I used It incorrectly, now when it is installed correctly - everything is fine @RemoGloor – frm Apr 16 '12 at 10:28
2

@bogert, what does "_when it is installed correctly_" mean ? could you please explain? – Fabio Salvalai Jul 01 '14 at 12:13

score 0 · Answer 2 · answered May 13 '20 at 08:44

This issue is caused by improper use of NInject.

To solve this issue In NinjectWebCommon class CreateKernel() method add kernel.Rebind<ModelValidatorProvider>().To<NinjectDefaultModelValidatorProvider>();

Here is the code sample.

private static IKernel CreateKernel()
        {
            var kernel = new StandardKernel();
            try
            {
                kernel.Bind<Func<IKernel>>().ToMethod(ctx => () => new Bootstrapper().Kernel);
                kernel.Bind<IHttpModule>().To<HttpApplicationInitializationHttpModule>();
                RegisterServices(kernel);
                GlobalConfiguration.Configuration.DependencyResolver = new NinjectDependencyResolver(kernel);
                kernel.Rebind<ModelValidatorProvider>().To<NinjectDefaultModelValidatorProvider>();
                return kernel;
            }
            catch
            {
                kernel.Dispose();
                throw;
            }
        }

Validation Attribute get triggered two times

2 Answers2

Linked