Is there a way for me to simplify this subversion pre-commit hook?

Question

Is there a way for me to simplify this pre-commit hook? It seems a bit much to me

#!/bin/sh
message=`$SVNLOOK log -t "$TXN" "$REPOS"`

# Block any commits which don't reference a ticket
if echo $message | grep -q "re #"
then
    :
elif echo $message | grep -q "references #"
then
    :
elif echo $message | grep -q "refs #"
then
    :
elif echo $message | grep -q "see #"
then
    :
elif echo $message | grep -q "addresses #"
then
    :
else
    echo "Your commit must reference a ticket to be accepted. For example, re #1234"
fi

score 1 · Answer 1 · answered Sep 09 '11 at 08:58

1

Should do the trick.

answered Sep 09 '11 at 08:58

gnur

149
7

very nice, I should have known that regex has OR syntax! – David Sep 12 '11 at 01:31

score 1 · Accepted Answer · answered Sep 09 '11 at 09:07

1

For this, you could use either gnur's variant or use a pattern file:

grep -q --file="matchpatterns.txt"

which would contain every pattern you want to accept:

refs #
addresses #
ticket #
bug #
...

I like this more because this kind of list tends to become long very quick, making the inline pattern difficult to manage.

answered Sep 09 '11 at 09:07

Sven

98,649
14
180
226

This is definitely the simplest and easiest to maintain! – David Sep 12 '11 at 01:31

Is there a way for me to simplify this subversion pre-commit hook?

2 Answers2