1

I have a simple model that I used as a request payload

public class CommandRequest
{
    public CommandType Type { get; set; }
    public dynamic Attributes { get; set; }
}

In controller action I need to read some property from dynamic Attributes

public async Task<IActionResult> Commands([FromBody] CommandRequest requestBody)
{
    string name = requestBody.Attributes.Name;
    ...
}

Got the following exception:

Microsoft.CSharp.RuntimeBinder.RuntimeBinderException: 'System.Text.Json.JsonElement' does not contain a definition for 'Name'

How can I read that property?

Я TChebur
  • 366
  • 6
  • 23

2 Answers2

3

Simply declaring something as dynamic doesn't guarantee that the resulting concrete object implements IDynamicMetaObjectProvider and allows for runtime definition of properties. Rather, dynamic simply means an object to which all compile-time checking has been turned off, and so all method and member references to it will be resolved in runtime. See:

Now, when you deserialize a JSON object to a member declared as dynamic with Json.NET, Newtonsoft will chose JObject as the concrete type to which to deserialize. As its base type JToken implements IDynamicMetaObjectProvider you can do things like requestBody.Attributes.Name and the .Net runtime will forward the property resolution to the JObject which will look the property up inside its list of properties. However, this doesn't happen automatically, Newtonsoft had to enhance JToken to make dynamic property access possible.

System.Text.Json, however, does not have built-in support for deserializing free-form JSON to some custom type implementing IDynamicMetaObjectProvider, so you will need to use the compile-time methods of the actual type returned, viz. JsonElement, to access the JSON data contained therein:

var name = requestBody.Attributes.GetProperty("Name").ToString();

Or, you could cast it for clarity:

var name = ((JsonElement)requestBody.Attributes).GetProperty("Name").ToString();

Demo fiddle here.

dbc
  • 104,963
  • 20
  • 228
  • 340
2
  1. You can use the GetProperty method on the JsonElement to get the property you desire.
  2. You can deserialize with JsonConvert.Deseralize("jsonpayload") to the model of Attributes and get Name directly with the "." notation.
  3. You can deserialize to Dictionary<string,string> and get the property name as Dict["Name"].
Michaelsoft
  • 777
  • 5
  • 18
  • 1
    Because dynamic objects sent via body arrive to the controller as a JsonObject. to access their properties as you would normally you have to deserialize them to their correct model or use JsonObject methods to get the property first and its value later with a "GetString" or similar. Dynamic objects kinda "loose" their original type when you pass them, you need to cast/deserialize/etc. them to something you can use. – Michaelsoft Sep 23 '20 at 21:33