Create Object (in ViewSet class) with Celery Task in Django

Question

Hello I encountered a problem which i am not able to solve by myself. I tried to call function create_with_celery inside create but it didnt work

How should I call create.delay with proper arguments? I don't know how to properly call create function to make workers create objects

class ArticleViewSet(viewsets.ModelViewSet):
    queryset = Article.objects.all()
    serializer_class = ArticleSerializer
    @app.task(bind=True)
    def create(self, request):
        article = Article.objects.create(link=request.data['link'])
        article.save()
        serializer = ArticleSerializer(article, many=False)

        words = WordList(article.link)
        # take every 90nth word for faster loading only dev approach
        i = 0
        for word in range(0, len(words.list)):

            # try to take word from database
            i += 1
            try:
                existing_word = Word.objects.filter(name=words[word])
                Word.objects.create(
                    name=existing_word[0].name,
                    advance_level=existing_word[0].advance_level,
                    definition=existing_word[0].definition,
                    article=Article.objects.get(id=article.id)
                )
                print('word nr {}/{} "{}" created from database'.format(i,
                                                                        len(words.list), words[word]))

            except:
                # if it's not existing fetch data from web
                Word.objects.create(
                    name=words[word],
                    advance_level=get_word_frequency(words[word]),
                    definition=get_word_definition(words[word]),
                    article=Article.objects.get(id=article.id)
                )
                print('word nr {}/{} "{}" fetched from web'.format(i,
                                                                   len(words.list), words[word]))

        response = {'message': 'Article created ', 'result': serializer.data}
        return Response(response, status=status.HTTP_200_OK)

Im trying to do something like this but I get error "Object of type 'Article' is not JSON serializable"

class ArticleViewSet(viewsets.ModelViewSet):
    queryset = Article.objects.all()
    serializer_class = ArticleSerializer

    @app.task(bind=True)
    def create_with_celery(self, article, serializer, words, req):
        i = 0
        for word in range(0, len(words.list)):
            # try to take word from database
            i += 1
            try:
                existing_word = Word.objects.filter(name=words[word])
                Word.objects.create(
                    name=existing_word[0].name,
                    advance_level=existing_word[0].advance_level,
                    definition=existing_word[0].definition,
                    article=Article.objects.get(id=article.id)
                )

                print('word nr {}/{} "{}" created from database'.format(i,
                                                                        len(words.list), words[word]))

            except:
                # if it's not existing fetch data from web
                Word.objects.create(
                    name=words[word],
                    advance_level=get_word_frequency(words[word]),
                    definition=get_word_definition(words[word]),
                    article=Article.objects.get(id=article.id)
                )
                print('word nr {}/{} "{}" fetched from web'.format(i,len(words.list), words[word]))


def create(self, request):
    article = Article.objects.create(link=request.data['link'])
    article.save()
    serializer = ArticleSerializer(article, many=False)
    words = WordList(article.link)
    req = request

    self.create_with_celery.delay(article, serializer, words, req)

    response = {'message': 'Article created ', 'result': serializer.data}
    return Response(response, status=status.HTTP_200_OK)

Hey I'm having similar issue. Did you solve it? @Adrian Zyskowski — Yashaswini Bhat, Feb 14 '21 at 02:31
@YashaswiniBhat As someone mentioned below you can only pass basic JSON to celery. You can't pass directly ModelViewSet's create function to celery with Python objects as arguments (self, request). — Adrian Zyskowski, Feb 15 '21 at 11:48
You should have your celery tasks in tasks.py file and these tasks should only receive basic types arguments (int, string, etc..) — Adrian Zyskowski, Feb 15 '21 at 11:51
I will try to answer you directly if you create another question on stack :) — Adrian Zyskowski, Feb 15 '21 at 12:07

score 1 · Answer 1 · answered May 28 '20 at 19:11

1

You can only pass basic types supported in JSON.

answered May 28 '20 at 19:11

Oriphiel

59
1
7

Do you maybe have an idea what would be a good implementation? – Adrian Zyskowski May 28 '20 at 23:04

score 1 · Answer 2 · answered May 28 '20 at 23:14

1

Take in mind that celery is a good tool to process async data, as I see what you try to do on ArticleViewSet, you could achieve that directly on the save method of the ArticleSerializer.

answered May 28 '20 at 23:14

guialante

96
7

You mean I can write the functions create and create_with_celery in serializers.py on ArticleSerializer? – Adrian Zyskowski May 29 '20 at 11:29
Yes that is the idea, use the Serializers as you use django Forms, in the views should not be all that heavy logic. – guialante May 29 '20 at 21:24

Create Object (in ViewSet class) with Celery Task in Django

2 Answers2