Creating a repetitive action in a GUI without 'time drift'

Question

A Swing based Timer is recommended for updating GUI components - because the calls to the components are automatically on the Event Dispatch Thread (the correct thread for updating Swing or AWT based components).

The Swing Timer though, has a tendency to 'drift' off time. If you create a timer that fires every second, after an hour or so, it might have drifted a few seconds above or below the elapsed time.

When using a Swing Timer to update a display which must be accurate (e.g. a countdown timer / stop watch), how do we avoid this time drift?

[StopWatch](https://stackoverflow.com/questions/50408678/adding-resume-function-to-stopwatch/50409049#50409049), [StopWatch](https://stackoverflow.com/questions/33487186/swing-timer-stopwatch-in-java/33488613#33488613), [StopWatch](https://stackoverflow.com/questions/21011914/creating-a-gui-based-chronometer-or-stopwatch/21012092#21012092) — MadProgrammer, Jan 06 '20 at 02:53

score 3 · Accepted Answer · answered Jan 06 '20 at 02:28

The trick here is to keep track of the elapsed time, check it frequently, and update the GUI when the actual time required ('one second' in this case) has passed.

Here is an example of doing that. Pay attention to the comments in the code.

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import javax.swing.border.EmptyBorder;

public class NonDriftingCountdownTimer {

    private JComponent ui = null;
    private Timer timer;
    private JLabel outputLabel;

    NonDriftingCountdownTimer() {
        initUI();
    }

    /** Keeps track of the start time and adjusts the count 
     * based on the ELAPSED time.
     * This should be used with a short time between listener calls. */
    class TimerActionListener implements ActionListener {
        long start = -1l;
        int duration;
        int count = 0;

        TimerActionListener(int duration) {
            this.duration = duration;
        }

        @Override
        public void actionPerformed(ActionEvent e) {
            long time = System.currentTimeMillis();
            if (start<0l) {
                start = time;
            } else {
                long next = start+(count*1000);
                if (time>next) {
                    count++;
                    outputLabel.setText((duration-count)+"");
                    if (count==duration) {
                        timer.stop();
                        JOptionPane.showMessageDialog(
                                outputLabel, "Time Is Up!");
                    }
                }
            }
        }
    }

    public final void initUI() {
        if (ui!=null) return;

        ui = new JPanel(new BorderLayout(4,4));
        ui.setBorder(new EmptyBorder(4,4,4,4));

        JPanel controlPanel = new JPanel();
        ui.add(controlPanel, BorderLayout.PAGE_START);
        final SpinnerNumberModel durationModel = 
                new SpinnerNumberModel(10, 1, 1200, 1);
        JSpinner spinner = new JSpinner(durationModel);
        controlPanel.add(spinner);

        JButton startButton = new JButton("Start");
        ActionListener startListener = (ActionEvent e) -> {
            int duration = durationModel.getNumber().intValue();
            TimerActionListener timerActionListener =
                    new TimerActionListener(duration);
            if (timer!=null) { timer.stop(); }
            // Note the short time of fire. This will allow accuracy
            // to within 1/50th of a second (without gradual drift).
            timer = new Timer(20, timerActionListener);
            timer.start();
        };
        startButton.addActionListener(startListener);
        controlPanel.add(startButton);

        outputLabel = new JLabel("0000", SwingConstants.TRAILING);
        outputLabel.setFont(new Font(Font.MONOSPACED, Font.BOLD, 200));
        ui.add(outputLabel);
    }

    public JComponent getUI() {
        return ui;
    }

    public static void main(String[] args) {
        Runnable r = () -> {
            try {
                UIManager.setLookAndFeel(
                        UIManager.getSystemLookAndFeelClassName());
            } catch (Exception useDefault) {
            }
            NonDriftingCountdownTimer o = new NonDriftingCountdownTimer();

            JFrame f = new JFrame(o.getClass().getSimpleName());
            f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
            f.setLocationByPlatform(true);

            f.setContentPane(o.getUI());
            f.pack();
            f.setMinimumSize(f.getSize());

            f.setVisible(true);
        };
        SwingUtilities.invokeLater(r);
    }
}

Personally, I'd use `Instant` and `Duration`, but I would guess it depends on your needs and goals — MadProgrammer, Jan 06 '20 at 02:54

Creating a repetitive action in a GUI without 'time drift'

1 Answers1