Return keyword in query callback

Question

Is it necessary to write return keyword while using whereHas in laravel.

For eg. return $query->where('status', 1);

$posts = App\Post::whereHas('comments', function ($query) {
    $query->whereHas('content', function ($query){
       $query->where('status', 1);
    });
})->get();

Do we need to write return in every query callback?

score 2 · Accepted Answer · answered Mar 25 '19 at 20:09

2

No, you're modifying the query builder instance passed to your closure by calling $query->where('status', 1);. Since objects are passed by reference and where() mutates this instance, there's no need to return anything.

answered Mar 25 '19 at 20:09

Devon Bessemer

34,461
9
69
95

https://stackoverflow.com/questions/55338139/conditional-where-on-the-basis-of-value-of-another-model/55338206#55338206 – sushant Mar 25 '19 at 20:20
1

Yeah, there's no need to return there so that answer wouldn't make a difference. – Devon Bessemer Mar 25 '19 at 20:36

score 0 · Answer 2 · answered Mar 25 '19 at 20:09

0

There is no need. Also you can use whereHas with nested relationship. Example:

$posts = App\Post::whereHas('comments.content', function ($query) {
    $query->where('status', 1);
})->get();

answered Mar 25 '19 at 20:09

Максим Купров

1
2

score 0 · Answer 3 · answered Mar 25 '19 at 20:11

0

No. Because you have the same object (and modify it) inside every function. No need to return.

answered Mar 25 '19 at 20:11

Petr

420
3
13

Return keyword in query callback

3 Answers3

Linked