UI won't update after getting json data from Openweathermap IOS 4 Xcode 10

Question

my JSON have been printed to console with the correct value request. but label.text and city.text won't update UI in main controller

@IBOutlet weak var icon: UIImageView!
@IBOutlet weak var date: UILabel!
@IBOutlet weak var weatherType: UILabel!
@IBOutlet weak var degree: UILabel!
@IBOutlet weak var city: UILabel!

var currentWeather : CurrentWeather!

override func viewDidLoad() {
    super.viewDidLoad()
    currentWeather = CurrentWeather()

}
override func viewDidAppear(_ animated: Bool) {
    super .viewDidAppear(animated)
    locationAuthStatus()

}

    func locationAuthStatus() {
        if CLLocationManager.authorizationStatus() == .authorizedWhenInUse {
            currentLocaion = locationManager.location
            //Location.sharedIntance.latitude = currentLocaion.coordinate.latitude
            //Location.sharedIntance.longitude = currentLocaion.coordinate.longitude
            print(currentLocaion)
            currentWeather.downloadWeatherDetail {
                downloadForecastData {
                    self.updateMainUI()
                }
            }

        } else {
            locationManager.requestWhenInUseAuthorization()
            locationAuthStatus()
        }
    }


func updateMainUI() {
    icon.image = UIImage(named: currentWeather.weatherType)
    city.text = currentWeather.cityName
    degree.text = "\(currentWeather.currentTemp)"
    weatherType.text = currentWeather.weatherType
    date.text = currentWeather.date
}

}

I am new to coding and 'm having a hard figuring out why isn't it showing since I confirmed that I am pulling data from Json to my console

this 'self.updateMainUI()' line of code is executed? if yes, then try putting it inside the main thread. `DisptachQueue.main.async { self.updateMainUI() }` — Bista, Aug 05 '18 at 05:05
yes have fixed the problem but now Alamofire won't stop request the Json data infinitely. thank you for your help — Marc Michel, Aug 06 '18 at 14:21

score 0 · Accepted Answer · answered Aug 05 '18 at 12:28

These lines won't do what you expect.

locationManager.requestWhenInUseAuthorization()
locationAuthStatus()

Your call to requestWhenInUseAuthorization is asynchronous and should be handled by a CLLocationManagerDelegate which can be your view controller. You can do this like this:

class ViewController: UITableViewController, CLLocationManagerDelegate {
// rest of class

Add these functions to your class

func locationManager(_ manager: CLLocationManager, didUpdateLocations objects: [CLLocation]) {
    let location = objects[objects.count-1]
    let currentLocation = location
        print(currentLocation)
        currentWeather.downloadWeatherDetail {
            downloadForecastData {
                self.updateMainUI()
            }
        }
}

func locationManager(_ manager: CLLocationManager, didFailWithError error: Error) {
    // handle error
}

func locationManager(_ manager: CLLocationManager, didChangeAuthorization status: CLAuthorizationStatus) {
    locationManager.startUpdatingLocation()

}

Thank you very much I implemented the function and it worked as it should — Marc Michel, Aug 05 '18 at 14:13

UI won't update after getting json data from Openweathermap IOS 4 Xcode 10

1 Answers1