ProgressBar in RecyclerView item not animating on notifyDataSetChanged

Question

I see a similar question here AnimationDrawable in RecyclerView item not animating on notifyDataSetChanged. But couldn't resolve this issue or fix. I think its because notifyDataSetChanged call multiple times to update UI. While I comment or notification change call for the position it works fine. I have three items in the recycled view.

Progress bar
Text view
Button

I need to call an API on button click and increment the textview value. while API calls I need to show the progress bar and hide while API finish

Button click as follow,

holder.image_add_overlay.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            holder.progressBar2.setVisibility(View.VISIBLE);             
            UpdateProductItem(holder, position);
        }
    });

private void UpdateProductItem(ShoppinglistAdapter.ViewHolder holder, int position) {
    try {
        Boolean value = CartFunctions.UpdateCartPostValue(cartAdd, mAPIService);
        if (value) {
            holder.text_item_cart_count.setText("" + holder.cart_count_value);
                // notifyDataSetChanged();
                holder.progressBar2.setVisibility(View.GONE);
                Task task = new Task();
                task.execute(); 
            Toast.makeText(context, context.getResources().getString(R.string.cart_update_toast_message), Toast.LENGTH_SHORT).show();
        } else {
            holder.cart_count_value = holder.cart_count_value - 1;
        }

    } catch (IOException e) {
        e.printStackTrace();
    }
}

I also try the

@SuppressLint("StaticFieldLeak")
public class Task extends AsyncTask<String, Integer, Integer> {

    @Override
    protected Integer doInBackground(String... strings) {
        Log.i("test", "doInBackground");
        // notifyDataSetChanged();
        return null;
    }

    @Override
    protected void onPostExecute(Integer integer) {
        Log.i("test", "onPostExecute");
        notifyDataSetChanged();
        super.onPostExecute(integer);
    }
}

And call the this using

Task task = new Task();
//task.doInBackground();
task.onPostExecute(0);

May the 2 item in recyclerview are same, so the count is shown to both become same. so i need notifyDataSetChanged() instead of notifyItemChanged(position); Did any guys know the solution?

@Vij i try with onPostExecute() ,but still the issue be same — Subin Babu, May 04 '18 at 10:36
Please add data related to `Progressbar` or `RecyclerView.Adapter` or `Activity`. — buzzingsilently, May 04 '18 at 10:57
@buzzingsilently i update the question, progress bar to just Visibility to Visible and Gone. Also, the text view to show the incremented data. I need notifyDataSetChanged() because i need to refresh entire adapter data — Subin Babu, May 04 '18 at 11:04
Add code for Button Click and work you are doing on API response. — buzzingsilently, May 04 '18 at 11:08
Now why do you need `notifyDataSetChanged()`?, Progressbar is VISIBLE & GONE at right places. — buzzingsilently, May 04 '18 at 11:17
I set the basics of my program in question, but in reality the data updated from other place and need to refresh all the updated value . may the 2 item in recyclerview are same, so the count is shown to both become same. so i need notifyDataSetChanged() instead of notifyItemChanged(position); — Subin Babu, May 04 '18 at 11:20
I feel using `interface` for RecyclerView item click will be better solution, refere this link. Implement onClick using interface. API calling & response in Activity class. DO NOT play with holder out side of Adapter bind method. — buzzingsilently, May 04 '18 at 11:22
sorry, here it is https://antonioleiva.com/recyclerview-listener/ — buzzingsilently, May 04 '18 at 11:24
it might be problem with arraylist that defined when insert or update your arraylist , make sure you made only single instance of list — Vij, May 04 '18 at 12:05
@Vij I think it's not related to ArrayList because I check it with 3 diff Adapter and ArrayList. But still the same issue — Subin Babu, May 04 '18 at 12:26

buzzingsilently · Answer 1 · 2018-05-04T10:50:17.323

1

doInBackground() method works in a separate thread, not even on UI thread.

Notify your adapter on UI thread, From AsyncTask : onPreExecute() & onPostExecute() method works on UI thread.

public class Task extends AsyncTask<Void, Void, Void> {

    @Override
    protected Void doInBackground(Void... params) {
        return null;
    }

    @Override
    protected void onPostExecute(Void result) {
        adapter.notifyDataSetChanged();
    }
}

Call your Task using,

Task task = new Task();
task.execute();

Refer AsynkTask for more details.

edited May 04 '18 at 10:50

answered May 04 '18 at 10:27

buzzingsilently

1,546
3
12
18

i update the question, let go through that, I still face the issue – Subin Babu May 04 '18 at 10:43
BTW, I have a doubt, Why do you need `AysncTask` here? – buzzingsilently May 04 '18 at 10:51
How do you get adapter.notifyDataSetChanged(); in onPostExecute(). – Subin Babu May 04 '18 at 10:52
Without AysncTask can we achive the ProgressBar in RecyclerView item not animating on notifyDataSetChanged – Subin Babu May 04 '18 at 10:52
Yes, I think it has nothing to do with `AsyncTask`. – buzzingsilently May 04 '18 at 10:56

ProgressBar in RecyclerView item not animating on notifyDataSetChanged

1 Answers1