MongoDB / Mongoose timestamps not updating

Question

Schema:

var schema = new Schema({...}, {
    timestamps: true,
    id: false,
    toJSON: {
        virtuals: true,
    },
    toObject: {
        virtual: true,
    }
});
schema.virtual('updated').get(function () {
    if(typeof this.updatedAt === "undefined" && typeof this.createdAt === "undefined") return "";
    var updated = (typeof this.updatedAt === "undefined") ? this.createdAt : this.updatedAt;
    return "Updated "+moment(updated).fromNow();
});

This code was working recently - updatedAt for a particular instance comes up as August 24th, however any new edits to the document doesn't update the timestamp.

Feels like I'm missing something very silly here.

I copy pasted your code and run on my server, and it is working perfectly fine with mongoose 4.6.1, So may be you are missing something somewhere else. Please mention mongoose version you are using, or any mongoose plugins. — Puneet Singh, Sep 27 '16 at 14:21
@PuneetSingh Mongoose v.4.5.3. Further testing shows that createdAt is created successfully and is correct, however the updatedAt value is not altered if we then update the document. Here's where I'm calling the edit: https://github.com/simon--poole/EventVODS/blob/master/app/routes/api/leaguesRouter.js#L103 — Simon Poole, Sep 27 '16 at 16:00
can check by `findOneAndUpdate()` instead of `findByIdAndUpdate()` ? — Shaishab Roy, Sep 30 '16 at 11:57
Looks like it was a known issue in mongoose timestamps. And the fix was done 3 days ago. May be you can update the Mongoose time stamps to latest version and try it?. More information on the fix is given in this link. https://github.com/drudge/mongoose-timestamp/pull/37/commits/969ede70a1afac1872efcbc85a2e68b6d12caa1e — Praveen Kumar, Sep 30 '16 at 15:23

Shaishab Roy · Answer 1 · 2016-09-27T11:48:49.987

Can try by modify your schema like:

var schema =new Schema({..}, 
           { timestamps: { createdAt: 'createdDate',updatedAt: 'updatedDate' } 
});

for this schema timestmps will update on save(), update() and findOneAndUpdate(). so no need schema.virtual('updated')...

Process-2

added createdDate and updatedDate with Date type in your schema and update these date fields using schema plugin.

like:

var mongoose = require('mongoose'),
    Schema   = mongoose.Schema,
    SchemaPlugin = require('../helpers/schemaPlugin');
  var schema =new Schema({..},
    createdDate: {
      type: Date,
      default: Date.now
    },
    updatedDate: {
      type: Date,
      default: Date.now
    }
  });

  schema.plugin(SchemaPlugin);

in schemaPlugin.js file:

module.exports = function(schema) {

  var updateTimestemps = function(next){
    var self = this;


    if(!self.createdAt) {
      self.createdDate = new Date();
      //or self.update({},{ $set: { createdDate : new Date(), updatedDate: new Date() } });
    } else {
      self.updatedDate= new Date();
      //or self.update({},{ $set: {updatedDate: new Date() } });
    }
    next();
  };

  schema.
    pre('save', updateTimestemps ).
    pre('update', updateTimestemps ).
    pre('findOneAndUpdate', updateTimestemps);
};

Nice! Your second suggestion is what I use. Worth mentioning the Mongoose docs [use the `.set()` method](https://mongoosejs.com/docs/middleware.html#notes) in their example, like this: `self.set({ updatedDate: new Date() });`. — Uche Ozoemena, Jul 02 '20 at 18:20

score 3 · Accepted Answer · answered Feb 26 '19 at 13:15

3

Stumbled upon the same thing, figured out that if the property updatedAt is set on my object when I'm updating it with findOneAndUpdate() (or update()), it won't update it.

In my case, solved it by making sure updatedAt isn't set before update:

delete thing.updatedAt;

Thing.findOneAndUpdate(
  { _id : thing._id },
  thing,
  function (err, result) {
   …

Credit to Valeri Karpov for his answer on Github.

answered Feb 26 '19 at 13:15

Maen

10,603
3
45
71

1

Well I gave up on this issue a long time ago, but that's much more elegant than my workaround - A+ catch. – Simon Poole Feb 26 '19 at 19:42

score 1 · Answer 3 · answered Sep 30 '16 at 13:08

updatedAt and createdAt both created on same time when a new document is entered into the database using mongoose so your checking of whether updatedAt is undefined or not is illogical as both will have the same value when new document is created.

Whenever you use a mongoose update function or findByIdAndUpdate or findOneAndUpdate the value of the updatedAt will be updated automatically.Use Mongodb client like mongochef or robomongo to directly check the value of the updatedAt.

The update function does not automatically updates `updatedAt`. If it does, then version `5.10.15` has a bug. — Sylar, Nov 22 '20 at 10:27

score 1 · Answer 4 · edited Jul 27 '23 at 13:11

1

I have facing this issue too. I solved it by move {timestamps: true} after schema structure. So it becomes like this:

edited Jul 27 '23 at 13:11

Mohammad Abd-Elmoniem

1
1
5
25

answered Jul 21 '23 at 09:56

Rickyz

11
2

Please post your code directly to the answer, no need of adding extra URLs that can become invalid in future. – Tyler2P Jul 27 '23 at 19:12

Maaz Ahmed · Answer 5 · 2023-08-14T10:45:21.807

1

use create method on model to get timestamps on doc creation const item = await Items.create({})

i faced the same issue and it worked for me.

i guess new keyword doesn't work, dunno why.

edited Aug 14 '23 at 10:45

answered Aug 14 '23 at 10:44

Maaz Ahmed

11
2

score 0 · Answer 6 · answered Sep 14 '16 at 17:41

0

You are comparing object with String, that's why condition is false always

schema.virtual('updated').get(function () {
    if(typeof this.updatedAt === undefined && typeof this.createdAt === undefined) return "";
    var updated = (typeof this.updatedAt === undefined) ? this.createdAt : this.updatedAt;
    return "Updated "+moment(updated).fromNow();
});

Try this, it should work

answered Sep 14 '16 at 17:41

abdulbarik

6,101
5
38
59

Thanks for the answer, but the issue doesn't seem to be with that part - the issue is with the updatedAt timestamp not updating on edit. – Simon Poole Sep 14 '16 at 17:48
in which place you are stuck? – abdulbarik Sep 14 '16 at 17:49
The Mongoose timestamp, updatedAt, is stuck at the same time - despite me updating the document since then. `updatedAt: "2016-08-24T12:28:39.842Z",`. The function to get the time _since_ then works fine. – Simon Poole Sep 14 '16 at 17:50

score 0 · Answer 7 · answered Sep 01 '23 at 11:10

0

I did this await Wallpaper.create(data, {session}) instead of

let wallpaper = new Wallpaper(data, { session })
wallpaper = await wallpaper.save()

and it works for me.

answered Sep 01 '23 at 11:10

Sanket Vanani

244
3
7

MongoDB / Mongoose timestamps not updating

7 Answers7